netdev - Re: [PATCH] net: fec: allow to build without PAGE_POOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 19 Jun 2023 10:06:43 +0200
From: Lucas Stach <l.stach@...gutronix.de>
To: Andrew Lunn <andrew@...n.ch>
Cc: "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Wei Fang <wei.fang@....com>,  Shenwei Wang
 <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, NXP Linux Team
 <linux-imx@....com>,  netdev@...r.kernel.org, kernel@...gutronix.de,
 patchwork-lst@...gutronix.de
Subject: Re: [PATCH] net: fec: allow to build without PAGE_POOL_STATS

Hi Andrew,

Am Samstag, dem 17.06.2023 um 17:48 +0200 schrieb Andrew Lunn:
> On Fri, Jun 16, 2023 at 09:18:32PM +0200, Lucas Stach wrote:
> > Commit 6970ef27ff7f ("net: fec: add xdp and page pool statistics") selected
> > CONFIG_PAGE_POOL_STATS from the FEC driver symbol, making it impossible
> > to build without the page pool statistics when this driver is enabled. The
> > help text of those statistics mentions increased overhead. Allow the user
> > to choose between usefulness of the statistics and the added overhead.
> 
> Hi Lucas
> 
> Do you have any sort of numbers?

I don't have any numbers. To be honest I only wrote this patch because
I was surprised to see CONFIG_PAGE_POOL_STATS being enabled via a
select after a kernel update, while the help text of that item suggests
that the user should have a choice here.

> 
> Object size should be easy to do.  How much difference does the #ifdef
> CONFIG_PAGE_POOL_STATS make to the code segment? Those come with a
> small amount of maintenance cost. And there does appear to be stubs
> for when PAGE_POOL_STATS is disabled.

Stubs aren't sufficient here, as the structures used as parameters to
those functions aren't defined when !CONFIG_PAGE_POOL_STATS.

Regards,
Lucas