netdev - RE: [PATCH v1 net-next] net: ena: Add missing newline after markup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac10789c93aa40b5b3f601ad968630c3@amazon.com>
Date: Tue, 20 Jun 2023 13:25:14 +0000
From: "Arinzon, David" <darinzon@...zon.com>
To: Simon Horman <simon.horman@...igine.com>
CC: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Woodhouse, David"
	<dwmw@...zon.co.uk>, "Machulsky, Zorik" <zorik@...zon.com>, "Matushevsky,
 Alexander" <matua@...zon.com>, "Bshara, Saeed" <saeedb@...zon.com>, "Wilson,
 Matt" <msw@...zon.com>, "Liguori, Anthony" <aliguori@...zon.com>, "Bshara,
 Nafea" <nafea@...zon.com>, "Saidi, Ali" <alisaidi@...zon.com>,
	"Herrenschmidt, Benjamin" <benh@...zon.com>, "Kiyanovski, Arthur"
	<akiyano@...zon.com>, "Dagan, Noam" <ndagan@...zon.com>, "Agroskin, Shay"
	<shayagr@...zon.com>, "Itzko, Shahar" <itzko@...zon.com>, "Abboud, Osama"
	<osamaabb@...zon.com>, kernel test robot <lkp@...el.com>
Subject: RE: [PATCH v1 net-next] net: ena: Add missing newline after markup

> On Tue, Jun 20, 2023 at 07:02:06AM +0000, darinzon@...zon.com wrote:
> > From: David Arinzon <darinzon@...zon.com>
> >
> > This patch fixes a warning in the ena documentation file identified by
> > the kernel automatic tools.
> >
> > Signed-off-by: David Arinzon <darinzon@...zon.com>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202306171804.U7E92zoE-lkp@intel.
> > com/
> > ---
> >  Documentation/networking/device_drivers/ethernet/amazon/ena.rst | 1
> +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > index 491492677632..00851ec7b4ec 100644
> > ---
> a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > +++
> b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > @@ -206,6 +206,7 @@ More information about Adaptive Interrupt
> > Moderation (DIM) can be found in
> Documentation/networking/net_dim.rst
> >
> >  .. _`RX copybreak`:
> > +
> >  RX copybreak
> >  ============
> >  The rx_copybreak is initialized by default to
> > ENA_DEFAULT_RX_COPYBREAK
> 
> Thanks David,
> 
> this looks good to me.
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> 
> Although it doesn't trigger a warning, the formatting of the text updated
> below doesn't seem right (I used make htmldocs).
> Feel free to take this if it is useful, or say the word and I'll submit it formally.
> 
> diff --git
> a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> index 00851ec7b4ec..5eaa3ab6c73e 100644
> --- a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> +++
> b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> @@ -38,6 +38,7 @@ debug logs.
> 
>  Some of the ENA devices support a working mode called Low-latency
> Queue (LLQ), which saves several more microseconds.
> +
>  ENA Source Code Directory Structure
>  ===================================
> 
> 

Hi Simon,

Thank you for reviewing and identifying this formatting issue, I'll submit a v2 today.