netdev - Re: [PATCH net-next v2 1/3] net: add check for current MAC address in dev_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <052d2f5a-ffeb-7c5b-814e-0cac4ddf7fa5@nvidia.com>
Date: Tue, 20 Jun 2023 19:25:20 +0300
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Piotr Gardocki <piotrx.gardocki@...el.com>, netdev@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, przemyslaw.kitszel@...el.com,
 michal.swiatkowski@...ux.intel.com, pmenzel@...gen.mpg.de,
 maciej.fijalkowski@...el.com, anthony.l.nguyen@...el.com,
 simon.horman@...igine.com, aleksander.lobakin@...el.com
Subject: Re: [PATCH net-next v2 1/3] net: add check for current MAC address in
 dev_set_mac_address

On 20/06/2023 18:59, Jakub Kicinski wrote:
> On Tue, 20 Jun 2023 13:42:14 +0300 Gal Pressman wrote:
>>> I checked it, you're right. When the addr_assign_type is PERM or RANDOM
>>> and user or some driver sets the same MAC address the type doesn't change
>>> to NET_ADDR_SET. In my testing I didn't notice issues with that, but I'm
>>> sure there are cases I didn't cover. Did you discover any useful cases
>>> that broke after this patch or did you just notice it in code?  
>>
>> This behavior change was caught in our regression tests.
> 
> Why was the regression test written this way?

This test environment is quite good at detecting state/behavior changes.

The test isn't written in any specific way, AFAIU we hit this patch flow
by default when using bonding (bond takes the first slave MAC address
and then sets the same address to all slaves?), it's not a test that
tries to set the same MAC address explicitly.