netdev - Re: [PATCH] netfilter: ipset: Replace strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 20 Jun 2023 13:28:24 -0700
From: Kees Cook <keescook@...omium.org>
To: fw@...len.de,
	pablo@...filter.org,
	azeemshaikh38@...il.com,
	kadlec@...filter.org
Cc: Kees Cook <keescook@...omium.org>,
	netfilter-devel@...r.kernel.org,
	kuba@...nel.org,
	pabeni@...hat.com,
	coreteam@...filter.org,
	linux-hardening@...r.kernel.org,
	davem@...emloft.net,
	edumazet@...gle.com,
	netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: ipset: Replace strlcpy with strscpy

On Tue, 13 Jun 2023 00:34:37 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> 
> [...]

Since this got Acked and it's a trivial change, I'll take this via the
hardening tree. Thanks!

Applied to for-next/hardening, thanks!

[1/1] netfilter: ipset: Replace strlcpy with strscpy
      https://git.kernel.org/kees/c/0b2fa86361f4

-- 
Kees Cook