netdev - Re: [PATCH iwl-next v5] iavf: fix err handling for MAC replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3dcd43c-0de6-e618-8f71-07f47a6b6071@intel.com>
Date: Tue, 20 Jun 2023 10:27:11 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Ahmed Zaki <ahmed.zaki@...el.com>, "Michal
 Swiatkowski" <michal.swiatkowski@...ux.intel.com>, Rafal Romanowski
	<rafal.romanowski@...el.com>, Piotr Gardocki <piotrx.gardocki@...el.com>
Subject: Re: [PATCH iwl-next v5] iavf: fix err handling for MAC replace

On 6/19/23 10:26, Maciej Fijalkowski wrote:
> On Mon, Jun 19, 2023 at 04:06:35AM -0400, Przemek Kitszel wrote:
>> Defer removal of current primary MAC until a replacement is successfully
>> added. Previous implementation would left filter list with no primary MAC.
>> This was found while reading the code.
>>
>> The patch takes advantage of the fact that there can only be a single primary
>> MAC filter at any time ([1] by Piotr)
>>
>> Piotr has also applied some review suggestions during our internal patch
>> submittal process.
>>
>> [1] https://lore.kernel.org/netdev/20230614145302.902301-2-piotrx.gardocki@intel.com/
>>
>> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
>> Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>
>> Signed-off-by: Piotr Gardocki <piotrx.gardocki@...el.com>
>> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> 
> I was reviewing that:
> https://lore.kernel.org/netdev/ZH8JBgiZAvNdfg4+@boxer/
> 
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

Thanks a lot both for insightful review, a remainder, and attitude :)

[...]