[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230620020113.2040080-1-renmingshuai@huawei.com>
Date: Tue, 20 Jun 2023 10:01:13 +0800
From: renmingshuai <renmingshuai@...wei.com>
To: <shaozhengchao@...wei.com>
CC: <caowangbao@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
<jhs@...atatu.com>, <jiri@...nulli.us>, <kuba@...nel.org>,
<liaichun@...wei.com>, <linux-kernel@...r.kernel.org>, <liubo335@...wei.com>,
<netdev@...r.kernel.org>, <pabeni@...hat.com>, <pctammela@...atatu.com>,
<renmingshuai@...wei.com>, <vladbu@...dia.com>, <xiyou.wangcong@...il.com>,
<yanan@...wei.com>
Subject: Re: [PATCH] selftests: tc-testing: add one test for flushing explicitly created chain
>Hi renmingshuai:
>On 2023/6/17 11:20, renmingshuai wrote:
>> Add the test for additional reference to chains that are explicitly created
>> by RTM_NEWCHAIN message
>>
>> commit c9a82bec02c3 ("net/sched: cls_api: Fix lockup on flushing explicitly
>> created chain")
>> Signed-off-by: Mingshuai Ren <renmingshuai@...wei.com>
>> ---
>> .../tc-testing/tc-tests/infra/filter.json | 25 +++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>> create mode 100644 tools/testing/selftests/tc-testing/tc-tests/infra/filter.json
>>
>> diff --git a/tools/testing/selftests/tc-testing/tc-tests/infra/filter.json b/tools/testing/selftests/tc-testing/tc-tests/infra/filter.json
>> new file mode 100644
>> index 000000000000..c4c778e83da2
>> --- /dev/null
>> +++ b/tools/testing/selftests/tc-testing/tc-tests/infra/filter.json
>> @@ -0,0 +1,25 @@
>> +[
>> + {
>> + "id": "c2b4",
>> + "name": "soft lockup alarm will be not generated after delete the prio 0 filter of the chain",
> "Delete the prio 0 filter of chain" looks better. And adding
> test result in comment also will be better.
>
>Zhengchao Shao
Thanks for your advice, and I have add the test result in comment.
https://lore.kernel.org/netdev/20230620014939.2034054-1-renmingshuai@huawei.com/T/#u
The original name can describe the purpose of adding the test case, which would be better.
Powered by blists - more mailing lists