netdev - Re: [PATCH v9 00/14] pci: Work around ASMedia ASM2824 PCIe link training failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 20 Jun 2023 10:54:04 +0100 (BST)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Bjorn Helgaas <helgaas@...nel.org>
cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, 
    Eric Dumazet <edumazet@...gle.com>, Oliver O'Halloran <oohall@...il.com>, 
    Stefan Roese <sr@...x.de>, Leon Romanovsky <leon@...nel.org>, 
    linux-rdma@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, 
    Paolo Abeni <pabeni@...hat.com>, Jim Wilson <wilson@...iptree.org>, 
    Nicholas Piggin <npiggin@...il.com>, 
    Alex Williamson <alex.williamson@...hat.com>, 
    Bjorn Helgaas <bhelgaas@...gle.com>, 
    Mika Westerberg <mika.westerberg@...ux.intel.com>, 
    David Abdurachmanov <david.abdurachmanov@...il.com>, 
    linuxppc-dev@...ts.ozlabs.org, Mahesh J Salgaonkar <mahesh@...ux.ibm.com>, 
    "David S. Miller" <davem@...emloft.net>, Lukas Wunner <lukas@...ner.de>, 
    netdev@...r.kernel.org, Pali Rohár <pali@...nel.org>, 
    Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH v9 00/14] pci: Work around ASMedia ASM2824 PCIe link
 training failures

On Fri, 16 Jun 2023, Bjorn Helgaas wrote:

> I agree that as I rearranged it, the workaround doesn't apply in all
> cases simultaneously.  Maybe not ideal, but maybe not terrible either.
> Looking at it again, maybe it would have made more sense to move the
> pcie_wait_for_link_delay() change to the last patch along with the
> pci_dev_wait() change.  I dunno.

 I think the order of the changes is not important enough to justify 
spending a lot of time and mental effort on it.  You decided, so be it.  
Thank you for your effort made with this review.

 With this series out of the way I have now posted a small clean-up for 
SBR code duplication between PCI core and an InfiniBand driver I came 
across in the course of working on this series.  See 
<https://lore.kernel.org/r/alpine.DEB.2.21.2306200153110.14084@angie.orcam.me.uk/>.

 Please have a look at your convenience.

  Maciej