netdev - RE: [PATCH v10 vfio 3/7] vfio/pds: register with the pds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 20 Jun 2023 02:11:03 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Brett Creeley <bcreeley@....com>, Brett Creeley <brett.creeley@....com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "alex.williamson@...hat.com"
	<alex.williamson@...hat.com>, "jgg@...dia.com" <jgg@...dia.com>,
	"yishaih@...dia.com" <yishaih@...dia.com>,
	"shameerali.kolothum.thodi@...wei.com" <shameerali.kolothum.thodi@...wei.com>
CC: "shannon.nelson@....com" <shannon.nelson@....com>
Subject: RE: [PATCH v10 vfio 3/7] vfio/pds: register with the pds_core PF

> From: Brett Creeley <bcreeley@....com>
> Sent: Saturday, June 17, 2023 3:02 AM
> >
> >>
> >> +#define PDS_LM_DEV_NAME              PDS_CORE_DRV_NAME "."
> >> PDS_DEV_TYPE_LM_STR
> >> +
> >
> > should this name include a 'vfio' string?
> 
> This aligns with what our DSC/firmware expects, so no it's not needed.

/**
 * pds_client_register - Link the client to the firmware
 * @pf_pdev:    ptr to the PF driver struct
 * @devname:    name that includes service into, e.g. pds_core.vDPA

The comment mentions vDPA which confused me on whether the client
should include a keyword of client to differentiate.

e.g. here the name is "pds_core.LM". If both VFIO/vDPA want to support
live migration with pds_core will there be a conflict or fine for multiple
drivers registering to a same service?