netdev - Re: [PATCH 06/11] sysctl: Add size to register_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f95b7489-8654-435c-bc74-da1eac479fba@kadam.mountain>
Date: Wed, 21 Jun 2023 13:49:54 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Joel Granados <j.granados@...sung.com>
Cc: mcgrof@...nel.org, Jason Gunthorpe <jgg@...pe.ca>,
	Leon Romanovsky <leon@...nel.org>, David Ahern <dsahern@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Joerg Reuter <jreuter@...na.de>, Ralf Baechle <ralf@...ux-mips.org>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	Florian Westphal <fw@...len.de>, Roopa Prabhu <roopa@...dia.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Alexander Aring <alex.aring@...il.com>,
	Stefan Schmidt <stefan@...enfreihafen.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Matthieu Baerts <matthieu.baerts@...sares.net>,
	Mat Martineau <martineau@...nel.org>,
	Simon Horman <horms@...ge.net.au>, Julian Anastasov <ja@....bg>,
	Remi Denis-Courmont <courmisch@...il.com>,
	Santosh Shilimkar <santosh.shilimkar@...cle.com>,
	David Howells <dhowells@...hat.com>,
	Marc Dionne <marc.dionne@...istor.com>,
	Neil Horman <nhorman@...driver.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
	Xin Long <lucien.xin@...il.com>,
	Karsten Graul <kgraul@...ux.ibm.com>,
	Wenjia Zhang <wenjia@...ux.ibm.com>,
	Jan Karcher <jaka@...ux.ibm.com>, Jon Maloy <jmaloy@...hat.com>,
	Ying Xue <ying.xue@...driver.com>, Martin Schiller <ms@....tdt.de>,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, linux-hams@...r.kernel.org,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	bridge@...ts.linux-foundation.org, dccp@...r.kernel.org,
	linux-wpan@...r.kernel.org, mptcp@...ts.linux.dev,
	lvs-devel@...r.kernel.org, rds-devel@....oracle.com,
	linux-afs@...ts.infradead.org, linux-sctp@...r.kernel.org,
	linux-s390@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
	linux-x25@...r.kernel.org
Subject: Re: [PATCH 06/11] sysctl: Add size to register_net_sysctl function

On Wed, Jun 21, 2023 at 12:47:30PM +0300, Dan Carpenter wrote:
> The patchset doesn't include the actual interesting changes, just a
> bunch of mechanical prep work.
> 

I was wrong here, the patchset just hadn't all hit the mailing lists.
I can't apply this patchset to anything.  I tried linux-next, net, and
net-next.  So it's hard to review.

It looks like ensure_safe_net_sysctl() never got update to use
table_size...

You could easily write a static checker test to print a warning any time
that ->procname is checked for NULL.  I have attached a Smatch check.
You would need to added to check_list.h and recompile.

net/sysctl_net.c:130 ensure_safe_net_sysctl() warn: checking ->procname 'ent->procname'

regards,
dan carpenter


View attachment "check_checking_procname.c" of type "text/x-csrc" (482 bytes)