netdev - Re: [PATCH net-next v2 03/15] idpf: add controlq init and reset checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 21 Jun 2023 12:14:39 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
 <pabeni@...hat.com>, <edumazet@...gle.com>, <netdev@...r.kernel.org>,
 Joshua Hay <joshua.a.hay@...el.com>, <emil.s.tantilov@...el.com>,
 <jesse.brandeburg@...el.com>, <sridhar.samudrala@...el.com>,
 <shiraz.saleem@...el.com>, <sindhu.devale@...el.com>, <willemb@...gle.com>,
 <decot@...gle.com>, <andrew@...n.ch>, <leon@...nel.org>, <mst@...hat.com>,
 <simon.horman@...igine.com>, <shannon.nelson@....com>,
 <stephen@...workplumber.org>, Alan Brady <alan.brady@...el.com>, "Madhu
 Chittim" <madhu.chittim@...el.com>, Phani Burra <phani.r.burra@...el.com>,
 Shailendra Bhatnagar <shailendra.bhatnagar@...el.com>
Subject: Re: [PATCH net-next v2 03/15] idpf: add controlq init and reset
 checks

On Wed, 21 Jun 2023 12:05:54 -0700 Linga, Pavan Kumar wrote:
> >> +void *idpf_alloc_dma_mem(struct idpf_hw *hw, struct idpf_dma_mem *mem, u64 size)
> >> +{
> >> +	struct idpf_adapter *adapter = hw->back;
> >> +	size_t sz = ALIGN(size, 4096);
> >> +
> >> +	mem->va = dma_alloc_coherent(&adapter->pdev->dev, sz,
> >> +				     &mem->pa, GFP_KERNEL | __GFP_ZERO);  
> > 
> > DMA API always zeros memory, I thought cocci warns about this
> > Did you run cocci checks?
> 
> I ran cocci check using the command "make -j8 
> M=drivers/net/ethernet/intel/idpf/ C=1 CHECK="scripts/coccicheck" 
> CONFIG_IDPF=m &>>err.log" but didn't see any hits and not sure if this 
> is the right command to see the warning. Will fix it anyways.

Ugh, disappointing, looks like people how were chasing these flags
throughout the tree couldn't be bothered to upstream the cocci check.
Or even document it, it seems? :| See 750afb08ca7131 as the initial
commit, FWIW, sorry to misdirect towards coccicheck.