Message-ID: <2a5a069572b46b59dd16fe8d54e549a9b5bbb6eb.camel@kernel.org>
Date: Wed, 21 Jun 2023 15:52:27 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Jeremy Kerr <jk@...abs.org>, Arnd Bergmann <arnd@...db.de>, Michael
 Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>, Heiko Carstens
 <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
 <agordeev@...ux.ibm.com>, Christian Borntraeger
 <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Arve
 Hjønnevåg <arve@...roid.com>, Todd Kjos
 <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>, Joel Fernandes
 <joel@...lfernandes.org>, Christian Brauner <brauner@...nel.org>, Carlos
 Llamas <cmllamas@...gle.com>, Suren Baghdasaryan <surenb@...gle.com>,
 Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>, Jason
 Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, Brad Warrum
 <bwarrum@...ux.ibm.com>, Ritu Agarwal <rituagar@...ux.ibm.com>, Eric Van
 Hensbergen <ericvh@...nel.org>, Latchesar Ionkov <lucho@...kov.net>,
 Dominique Martinet <asmadeus@...ewreck.org>, Christian Schoenebeck
 <linux_oss@...debyte.com>, David Sterba <dsterba@...e.com>, David Howells
 <dhowells@...hat.com>, Marc Dionne <marc.dionne@...istor.com>, Alexander
 Viro <viro@...iv.linux.org.uk>, Ian Kent <raven@...maw.net>, Luis de
 Bethencourt <luisbg@...nel.org>, Salah Triki <salah.triki@...il.com>,
 "Tigran A. Aivazian" <aivazian.tigran@...il.com>, Eric Biederman
 <ebiederm@...ssion.com>, Kees Cook <keescook@...omium.org>, Chris Mason
 <clm@...com>, Josef Bacik <josef@...icpanda.com>, Xiubo Li
 <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>, Jan Harkes
 <jaharkes@...cmu.edu>, coda@...cmu.edu, Joel Becker <jlbec@...lplan.org>,
 Christoph Hellwig <hch@....de>, Nicolas Pitre <nico@...xnic.net>,  "Rafael
 J. Wysocki" <rafael@...nel.org>, Tyler Hicks <code@...icks.com>, Ard
 Biesheuvel <ardb@...nel.org>, Gao Xiang <xiang@...nel.org>, Chao Yu
 <chao@...nel.org>,  Yue Hu <huyue2@...lpad.com>, Jeffle Xu
 <jefflexu@...ux.alibaba.com>, Namjae Jeon <linkinjeon@...nel.org>, Sungjong
 Seo <sj1557.seo@...sung.com>, Jan Kara <jack@...e.com>, Theodore Ts'o
 <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, Jaegeuk Kim
 <jaegeuk@...nel.org>, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>, Miklos
 Szeredi <miklos@...redi.hu>, Bob Peterson <rpeterso@...hat.com>, Andreas
 Gruenbacher <agruenba@...hat.com>, Richard Weinberger <richard@....at>,
 Anton Ivanov <anton.ivanov@...bridgegreys.com>, Johannes Berg
 <johannes@...solutions.net>, Mikulas Patocka
 <mikulas@...ax.karlin.mff.cuni.cz>,  Mike Kravetz
 <mike.kravetz@...cle.com>, Muchun Song <muchun.song@...ux.dev>, David
 Woodhouse <dwmw2@...radead.org>, Dave Kleikamp <shaggy@...nel.org>, Tejun
 Heo <tj@...nel.org>, Trond Myklebust <trond.myklebust@...merspace.com>,
 Anna Schumaker <anna@...nel.org>, Chuck Lever <chuck.lever@...cle.com>,
 Ryusuke Konishi <konishi.ryusuke@...il.com>, Anton Altaparmakov
 <anton@...era.com>,  Konstantin Komarov
 <almaz.alexandrovich@...agon-software.com>, Mark Fasheh <mark@...heh.com>,
 Joseph Qi <joseph.qi@...ux.alibaba.com>, Bob Copeland <me@...copeland.com>,
 Mike Marshall <hubcap@...ibond.com>, Martin Brandenburg
 <martin@...ibond.com>, Luis Chamberlain <mcgrof@...nel.org>, Iurii Zaikin
 <yzaikin@...gle.com>, Tony Luck <tony.luck@...el.com>,  "Guilherme G.
 Piccoli" <gpiccoli@...lia.com>, Anders Larsen <al@...rsen.net>, Steve
 French <sfrench@...ba.org>, Paulo Alcantara <pc@...guebit.com>, Ronnie
 Sahlberg <lsahlber@...hat.com>, Shyam Prasad N <sprasad@...rosoft.com>, Tom
 Talpey <tom@...pey.com>, Sergey Senozhatsky <senozhatsky@...omium.org>,
 Phillip Lougher <phillip@...ashfs.org.uk>, Masami Hiramatsu
 <mhiramat@...nel.org>, Evgeniy Dushistov <dushistov@...l.ru>, Hans de Goede
 <hdegoede@...hat.com>, "Darrick J. Wong" <djwong@...nel.org>, Damien Le
 Moal <dlemoal@...nel.org>, Naohiro Aota <naohiro.aota@....com>, Johannes
 Thumshirn <jth@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,
 Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP
 Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Hao Luo
 <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,  Hugh Dickins
 <hughd@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, John Johansen
 <john.johansen@...onical.com>, Paul Moore <paul@...l-moore.com>, James
 Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, Stephen
 Smalley <stephen.smalley.work@...il.com>, Eric Paris
 <eparis@...isplace.org>,  Juergen Gross <jgross@...e.com>, Ruihan Li
 <lrh2000@....edu.cn>, Laurent Pinchart
 <laurent.pinchart+renesas@...asonboard.com>, Wolfram Sang
 <wsa+renesas@...g-engineering.com>, Udipto Goswami
 <quic_ugoswami@...cinc.com>,  Linyu Yuan <quic_linyyuan@...cinc.com>, John
 Keeping <john@...ping.me.uk>, Andrzej Pietrasiewicz
 <andrzej.p@...labora.com>, Dan Carpenter <error27@...il.com>, Yuta Hayama
 <hayama@...eo.co.jp>, Jozef Martiniak <jomajm@...il.com>, Jens Axboe
 <axboe@...nel.dk>, Alan Stern <stern@...land.harvard.edu>, Sandeep Dhavale
 <dhavale@...gle.com>, Dave Chinner <dchinner@...hat.com>, Johannes Weiner
 <hannes@...xchg.org>, ZhangPeng <zhangpeng362@...wei.com>, Viacheslav
 Dubeyko <slava@...eyko.com>, Tetsuo Handa
 <penguin-kernel@...ove.SAKURA.ne.jp>,  Aditya Garg <gargaditya08@...e.com>,
 Erez Zadok <ezk@...stonybrook.edu>, Yifei Liu <yifeliu@...stonybrook.edu>,
 Yu Zhe <yuzhe@...china.com>, "Matthew Wilcox (Oracle)"
 <willy@...radead.org>, Oleg Kanatov <okanatov@...il.com>, "Dr. David Alan
 Gilbert" <linux@...blig.org>, Jiangshan Yi <yijiangshan@...inos.cn>, xu xin
 <cgel.zte@...il.com>, Stefan Roesch <shr@...kernel.io>, Zhihao Cheng
 <chengzhihao1@...wei.com>, "Liam R. Howlett" <Liam.Howlett@...cle.com>, 
 Alexey Dobriyan <adobriyan@...il.com>, Minghao Chi
 <chi.minghao@....com.cn>, Seth Forshee <sforshee@...italocean.com>, Zeng
 Jingxiang <linuszeng@...cent.com>, Bart Van Assche <bvanassche@....org>,
 Mimi Zohar <zohar@...ux.ibm.com>, Roberto Sassu <roberto.sassu@...wei.com>,
 Zhang Yi <yi.zhang@...wei.com>, Tom Rix <trix@...hat.com>, "Fabio M. De
 Francesco" <fmdefrancesco@...il.com>, Chen Zhongjin
 <chenzhongjin@...wei.com>, Zhengchao Shao <shaozhengchao@...wei.com>, Rik
 van Riel <riel@...riel.com>, Jingyu Wang <jingyuwang_vip@....com>, Hangyu
 Hua <hbh25y@...il.com>, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org,  linux-s390@...r.kernel.org,
 linux-rdma@...r.kernel.org,  linux-usb@...r.kernel.org,
 v9fs@...ts.linux.dev, linux-fsdevel@...r.kernel.org, 
 linux-afs@...ts.infradead.org, autofs@...r.kernel.org, linux-mm@...ck.org, 
 linux-btrfs@...r.kernel.org, ceph-devel@...r.kernel.org, 
 codalist@...a.cs.cmu.edu, ecryptfs@...r.kernel.org,
 linux-efi@...r.kernel.org,  linux-erofs@...ts.ozlabs.org,
 linux-ext4@...r.kernel.org,  linux-f2fs-devel@...ts.sourceforge.net,
 cluster-devel@...hat.com,  linux-um@...ts.infradead.org,
 linux-mtd@...ts.infradead.org,  jfs-discussion@...ts.sourceforge.net,
 linux-nfs@...r.kernel.org,  linux-nilfs@...r.kernel.org,
 linux-ntfs-dev@...ts.sourceforge.net,  ntfs3@...ts.linux.dev,
 ocfs2-devel@....oracle.com,  linux-karma-devel@...ts.sourceforge.net,
 devel@...ts.orangefs.org,  linux-unionfs@...r.kernel.org,
 linux-hardening@...r.kernel.org,  reiserfs-devel@...r.kernel.org,
 linux-cifs@...r.kernel.org,  samba-technical@...ts.samba.org,
 linux-trace-kernel@...r.kernel.org,  linux-xfs@...r.kernel.org,
 bpf@...r.kernel.org, netdev@...r.kernel.org,  apparmor@...ts.ubuntu.com,
 linux-security-module@...r.kernel.org,  selinux@...r.kernel.org
Subject: Re: [PATCH 00/79] fs: new accessors for inode->i_ctime

On Wed, 2023-06-21 at 15:21 -0400, Steven Rostedt wrote:
> On Wed, 21 Jun 2023 10:45:05 -0400
> Jeff Layton <jlayton@...nel.org> wrote:
> 
> > Most of this conversion was done via coccinelle, with a few of the more
> > non-standard accesses done by hand. There should be no behavioral
> > changes with this set. That will come later, as we convert individual
> > filesystems to use multigrain timestamps.
> 
> BTW, Linus has suggested to me that whenever a conccinelle script is used,
> it should be included in the change log.
> 

Ok, here's what I have. I note again that my usage of coccinelle is
pretty primitive, so I ended up doing a fair bit of by-hand fixing after
applying these.

Given the way that this change is broken up into 77 patches by
subsystem, to which changelogs should I add it? I could add it to the
"infrastructure" patch, but that's the one where I _didn't_ use it. 

Maybe to patch #79 (the one that renames i_ctime)?


------------------------8<------------------------------
@@
expression inode;
@@

- inode->i_ctime = current_time(inode)
+ inode_set_current_ctime(inode)

@@
expression inode;
@@

- inode->i_ctime = inode->i_mtime = current_time(inode)
+ inode->i_mtime = inode_set_current_ctime(inode)

@@
struct inode *inode;
expression value;
@@

- inode->i_ctime = value;
+ inode_set_ctime(inode, value);

@@
struct inode *inode;
expression val;
@@
- inode->i_ctime.tv_sec = val
+ inode_set_ctime_sec(inode, val)

@@
struct inode *inode;
expression val;
@@
- inode->i_ctime.tv_nsec = val
+ inode_set_ctime_nsec(inode, val)

@@
struct inode *inode;
@@
- inode->i_ctime
+ inode_ctime_peek(inode)

Powered by blists - more mailing lists