netdev - Re: [PATCH net-next v2 04/15] idpf: add core init and interrupt request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 21 Jun 2023 12:07:35 -0700
From: "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<netdev@...r.kernel.org>, <emil.s.tantilov@...el.com>,
	<jesse.brandeburg@...el.com>, <sridhar.samudrala@...el.com>,
	<shiraz.saleem@...el.com>, <sindhu.devale@...el.com>, <willemb@...gle.com>,
	<decot@...gle.com>, <andrew@...n.ch>, <leon@...nel.org>, <mst@...hat.com>,
	<simon.horman@...igine.com>, <shannon.nelson@....com>,
	<stephen@...workplumber.org>, Alan Brady <alan.brady@...el.com>, Joshua Hay
	<joshua.a.hay@...el.com>, Madhu Chittim <madhu.chittim@...el.com>, "Phani
 Burra" <phani.r.burra@...el.com>, Shailendra Bhatnagar
	<shailendra.bhatnagar@...el.com>
Subject: Re: [PATCH net-next v2 04/15] idpf: add core init and interrupt
 request



On 6/16/2023 11:50 PM, Jakub Kicinski wrote:
> On Wed, 14 Jun 2023 10:14:17 -0700 Tony Nguyen wrote:
>> + * @IDPF_REL_RES_IN_PROG: Resources release in progress
> 
>> + * @IDPF_CANCEL_SERVICE_TASK: Do not schedule service task if bit is set
>> + * @IDPF_REMOVE_IN_PROG: Driver remove in progress
> 
> Why all the X-in-progress flags, again?
> 

IDPF_REMOVE_IN_PROG is used for the conditional checks to indicate that 
the rmmod is in progress and there is no scope to process any hardware 
resets if the bit is set.

IDPF_HR_RESET_IN_PROG is used on hardware reset to not send any 
statistics message to the device Control Plane and to avoid releasing 
the configured netdevs if the bit is set.

After taking a deeper look, IDPF_REL_RES_IN_PROG does not serve the 
purpose as IDPF_REMOVE_IN_PROG already takes care of it. Will cleanup 
this flag.

>> +	set_bit(IDPF_CANCEL_SERVICE_TASK, adapter->flags);
>> +	cancel_delayed_work_sync(&adapter->serv_task);
>> +	clear_bit(IDPF_CANCEL_SERVICE_TASK, adapter->flags);
> 
> Pretty sure workqueue protects from self-requeueing.

Agree with you. Will remove both CANCEL_STATS_TASK and 
CANCEL_SERVICE_TASK flags.

Thanks,
Pavan