netdev - Re: [PATCH net-next v2 12/15] idpf: add RX splitq napi poll support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35e24b1a-00ab-84a0-db66-e0a11dfdfd29@intel.com>
Date: Wed, 21 Jun 2023 12:07:56 -0700
From: "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<netdev@...r.kernel.org>, Alan Brady <alan.brady@...el.com>,
	<emil.s.tantilov@...el.com>, <jesse.brandeburg@...el.com>,
	<sridhar.samudrala@...el.com>, <shiraz.saleem@...el.com>,
	<sindhu.devale@...el.com>, <willemb@...gle.com>, <decot@...gle.com>,
	<andrew@...n.ch>, <leon@...nel.org>, <mst@...hat.com>,
	<simon.horman@...igine.com>, <shannon.nelson@....com>,
	<stephen@...workplumber.org>, Joshua Hay <joshua.a.hay@...el.com>, "Madhu
 Chittim" <madhu.chittim@...el.com>, Phani Burra <phani.r.burra@...el.com>
Subject: Re: [PATCH net-next v2 12/15] idpf: add RX splitq napi poll support



On 6/16/2023 11:55 PM, Jakub Kicinski wrote:
> On Wed, 14 Jun 2023 10:14:25 -0700 Tony Nguyen wrote:
>> +	skb = __napi_alloc_skb(&rxq->q_vector->napi, IDPF_RX_HDR_SIZE,
>> +			       GFP_ATOMIC | __GFP_NOWARN);
> 
> Why are you trying to pass __GFP_NOWARN in?

I don't think it is required. Will remove it.

Thanks,
Pavan