netdev - Re: [PATCH] s390/net: lcs: use IS_ENABLED() for kconfig detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5306c89-eaaa-b357-0518-bdb9a0e5ae9f@infradead.org>
Date: Wed, 21 Jun 2023 14:19:15 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Simon Horman <simon.horman@...igine.com>
Cc: linux-kernel@...r.kernel.org, Alexandra Winter <wintera@...ux.ibm.com>,
 Wenjia Zhang <wenjia@...ux.ibm.com>, linux-s390@...r.kernel.org,
 netdev@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
 Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
 <agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>
Subject: Re: [PATCH] s390/net: lcs: use IS_ENABLED() for kconfig detection



On 6/21/23 12:37, Simon Horman wrote:
> On Wed, Jun 21, 2023 at 11:08:05AM -0700, Randy Dunlap wrote:
>> Hi Simon,
>>

>>> I did have better luck with this.
>>>
>>> diff --git a/drivers/s390/net/Kconfig b/drivers/s390/net/Kconfig
>>> index 9c67b97faba2..303220251495 100644
>>> --- a/drivers/s390/net/Kconfig
>>> +++ b/drivers/s390/net/Kconfig
>>> @@ -6,6 +6,7 @@ config LCS
>>>         def_tristate m
>>>         prompt "Lan Channel Station Interface"
>>>         depends on CCW && NETDEVICES && (ETHERNET || FDDI)
>>> +       depends on FDDI=y || FDDI=n
>>>         help
>>>           Select this option if you want to use LCS networking on IBM System z.
>>>           This device driver supports FDDI (IEEE 802.7) and Ethernet.
>>>
>>> I am assuming that LCS=m and FDDI=m can't work at runtime
>>> because there is no guarantee that FDDI is loaded before LCS.
>>> But I could well be wrong here.
>>
>> There's probably some way to make that work, but I don't know.
>>
>> I think that your patch is acceptable.
>> I would prefer to also add to the help text that if FDDI is used,
>> it must be builtin (=y).
> 
> Thanks Randy,
> 
> Feel free to take the snippet above and work it into a proper patch.
> Else I can take a shot at it.
> 

OK, I'll send that. Thanks.

-- 
~Randy