netdev - Re: [PATCH net-next] net: stmmac: propagate feature flags to vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 22 Jun 2023 10:20:34 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Corinna Vinschen <vinschen@...hat.com>
Cc: netdev@...r.kernel.org, Giuseppe Cavallaro <peppe.cavallaro@...com>,
	alexandre.torgue@...s.st.com, Jose Abreu <joabreu@...opsys.com>
Subject: Re: [PATCH net-next] net: stmmac: propagate feature flags to vlan

Hi Corinna,

this patch breaks netboot on PRTT1C. Reverting this patch make it works again.
Here is a boot log with reverted patch:
root@...t1c:~ dmesg | grep -e "\(ether\|sja\)"
[    2.523153] sja1105 spi0.0: Probed switch chip: SJA1105Q
[    2.534541] stm32-dwmac 5800a000.ethernet: IRQ eth_wake_irq not found
[    2.539678] stm32-dwmac 5800a000.ethernet: IRQ eth_lpi not found
[    2.564079] stm32-dwmac 5800a000.ethernet: User ID: 0x40, Synopsys ID: 0x42
[    2.569726] stm32-dwmac 5800a000.ethernet:   DWMAC4/5
[    2.582496] stm32-dwmac 5800a000.ethernet: DMA HW capability register supported
[    2.588415] stm32-dwmac 5800a000.ethernet: RX Checksum Offload Engine supported
[    2.612482] stm32-dwmac 5800a000.ethernet: TX Checksum insertion supported
[    2.617992] stm32-dwmac 5800a000.ethernet: Wake-Up On Lan supported
[    2.632481] stm32-dwmac 5800a000.ethernet: TSO supported
[    2.636369] stm32-dwmac 5800a000.ethernet: Enable RX Mitigation via HW Watchdog Timer
[    2.662493] stm32-dwmac 5800a000.ethernet: Enabled L3L4 Flow TC (entries=2)
[    2.668109] stm32-dwmac 5800a000.ethernet: Enabled RFS Flow TC (entries=10)
[    2.682494] stm32-dwmac 5800a000.ethernet: TSO feature enabled
[    2.686993] stm32-dwmac 5800a000.ethernet: Using 32/32 bits DMA host/device width
[    3.513207] sja1105 spi0.0: Probed switch chip: SJA1105Q
[    3.536541] stm32-dwmac 5800a000.ethernet eth0: Only single VLAN ID supported
[    3.544291] stm32-dwmac 5800a000.ethernet eth0: Only single VLAN ID supported
[    3.551823] stm32-dwmac 5800a000.ethernet eth0: Only single VLAN ID supported
[    3.559610] sja1105 spi0.0: configuring for fixed/rmii link mode
[    3.565608] sja1105 spi0.0: Link is Up - 100Mbps/Full - flow control off
[    3.575253] sja1105 spi0.0 t1l0 (uninitialized): PHY [gpio-0:06] driver [TI DP83TD510E] (irq=31)
[    3.594168] sja1105 spi0.0 t1l1 (uninitialized): PHY [gpio-0:07] driver [TI DP83TD510E] (irq=32)
[    3.612244] sja1105 spi0.0 t1l2 (uninitialized): PHY [gpio-0:0a] driver [TI DP83TD510E] (irq=33)
[    3.715610] sja1105 spi0.0 rj45 (uninitialized): PHY [gpio-0:02] driver [Micrel KSZ9031 Gigabit PHY] (irq=34)
[    3.729040] stm32-dwmac 5800a000.ethernet eth0: entered promiscuous mode
[    3.860011] stm32-dwmac 5800a000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0
[    3.876544] stm32-dwmac 5800a000.ethernet eth0: No Safety Features support found
[    4.084884] stm32-dwmac 5800a000.ethernet eth0: IEEE 1588-2008 Advanced Timestamp supported
[    4.092530] stm32-dwmac 5800a000.ethernet eth0: registered PTP clock
[    4.099997] stm32-dwmac 5800a000.ethernet eth0: configuring for fixed/rmii link mode
[    4.106645] stm32-dwmac 5800a000.ethernet eth0: Link is Up - 100Mbps/Full - flow control off
[    4.120533] stm32-dwmac 5800a000.ethernet eth0: Adding VLAN ID 0 is not supported
[    4.129557] sja1105 spi0.0 t1l0: configuring for phy/rmii link mode
[    4.143546] sja1105 spi0.0 t1l1: configuring for phy/rmii link mode
[    4.161097] sja1105 spi0.0 t1l2: configuring for phy/rmii link mode
[    4.167342] sja1105 spi0.0 rj45: configuring for phy/rgmii-id link mode
[    9.809396] sja1105 spi0.0 rj45: Link is Up - 1Gbps/Full - flow control off
[   66.587255] sja1105 spi0.0 t1l0: entered allmulticast mode
[   66.605179] stm32-dwmac 5800a000.ethernet eth0: entered allmulticast mode
[   66.624612] sja1105 spi0.0 t1l0: entered promiscuous mode
[   66.676943] sja1105 spi0.0 t1l1: entered allmulticast mode
[   66.700590] sja1105 spi0.0 t1l1: entered promiscuous mode
[   66.762670] sja1105 spi0.0 t1l2: entered allmulticast mode
[   66.782927] sja1105 spi0.0 t1l2: entered promiscuous mode
[   66.921089] sja1105 spi0.0 t1l0: configuring for phy/rmii link mode
[   66.951074] sja1105 spi0.0 t1l1: configuring for phy/rmii link mode
[   67.008160] sja1105 spi0.0 t1l2: configuring for phy/rmii link mode
[   68.557994] sja1105 spi0.0 t1l1: Link is Up - 10Mbps/Full - flow control off
[   93.820549] sja1105 spi0.0 t1l1: Link is Down
[   94.412697] sja1105 spi0.0 t1l1: Link is Up - 10Mbps/Full - flow control off
[   94.445096] stm32-dwmac 5800a000.ethernet eth0: Couldn't decode source port

Please tell me if you'll need help to debug this issue.

Regards,
Oleksij