netdev - RE: [PATCH v2 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB355842E84AA9C943EE402BE3EC5DA@BYAPR11MB3558.namprd11.prod.outlook.com>
Date: Wed, 21 Jun 2023 22:58:12 +0000
From: <Tristram.Ha@...rochip.com>
To: <kuba@...nel.org>
CC: <andrew@...n.ch>, <f.fainelli@...il.com>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v2 net-next] net: phy: smsc: add WoL support to
 LAN8740/LAN8742 PHYs

> On Wed, 14 Jun 2023 17:15:50 -0700 Tristram.Ha@...rochip.com wrote:
> > Microchip LAN8740/LAN8742 PHYs support basic unicast, broadcast, and
> > Magic Packet WoL.  They have one pattern filter matching up to 128 bytes
> > of frame data, which can be used to implement ARP or multicast WoL.
> >
> > ARP WoL matches ARP request for IPv4 address of the net device using the
> > PHY.
> >
> > Multicast WoL matches IPv6 Neighbor Solicitation which is sent when
> > somebody wants to talk to the net device using IPv6.  This
> > implementation may not be appropriate and can be changed by users later.
> 
> Quick look at lan743x and natsemi seems to indicate that WAKE_ARP means
> wake on _any_ arp, not arp directed to the local IPv4 addr.
> 
> Could you separate the changes to support other wake types out and post
> separately? We can merge that without much controversy. The ARP may
> need a discussion. My instinct is that since existing drivers interpret
> ARP as any ARP we should add a new type to the uAPI for local ARP.

It seems getting IP and IPv6 addresses from PHY driver is not well
supported or recommended, so a new patch just supporting generic ARP
and multicast WoL will be submitted.