netdev - Re: [net-next Patch 1/3] octeontx2-pf: implement transmit schedular allocation algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71f51047892001e6cdac1de4a6f7c2b9f97c7c8b.camel@redhat.com>
Date: Fri, 23 Jun 2023 15:01:09 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Hariprasad Kelam <hkelam@...vell.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Cc: kuba@...nel.org, davem@...emloft.net, willemdebruijn.kernel@...il.com, 
 andrew@...n.ch, sgoutham@...vell.com, lcherian@...vell.com,
 gakula@...vell.com,  jerinj@...vell.com, sbhatta@...vell.com,
 naveenm@...vell.com, edumazet@...gle.com,  jhs@...atatu.com,
 xiyou.wangcong@...il.com, jiri@...nulli.us, maxtram95@...il.com, 
 corbet@....net, linux-doc@...r.kernel.org
Subject: Re: [net-next Patch 1/3] octeontx2-pf: implement transmit schedular
 allocation algorithm

On Thu, 2023-06-22 at 14:26 +0530, Hariprasad Kelam wrote:
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> index 19773284be27..0c5d2f79dc15 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> @@ -35,6 +35,7 @@ struct otx2_qos_cfg {
>  	int dwrr_node_pos[NIX_TXSCH_LVL_CNT];
>  	u16 schq_contig_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC];
>  	u16 schq_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC];
> +	u16 schq_used_index[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC];

This struct is already quite big, and you use schq_used_index[x][y] as
a bool. I think you will be better off changing the used type
accordingly.

Side note 'schq_index_used' sounds a little more clear to me, but could
be simply ENONATIVELANG here ;)

Cheers,

Paolo