netdev - Re: [PATCH v3 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89f5731d-81fb-4da9-b919-c2a3b9e55779@lunn.ch>
Date: Fri, 23 Jun 2023 15:32:19 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Tristram.Ha@...rochip.com, Florian Fainelli <f.fainelli@...il.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v3 net-next] net: phy: smsc: add WoL support to
 LAN8740/LAN8742 PHYs

> > +	if (wol->wolopts & WAKE_ARP) {
> > +		u8 pattern[14] = {
> > +			0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF,
> > +			0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > +			0x08, 0x06 };
> > +		u16 mask[1] = { 0x303F };
> > +		u8 len = 14;
> 
> 'len' is never changed, you could use instead some macro with a
> meaningful name.

This looks to be ETH_HLEN.

     Andrew