netdev - Re: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230623152844.GA174017@bhelgaas>
Date: Fri, 23 Jun 2023 10:28:44 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
Cc: bjorn.helgaas@...il.com, Jinjian.Song@...ocom.com, Reid.he@...ocom.com,
	bjorn@...gaas.com, haijun.liu@...iatek.com, kuba@...nel.org,
	netdev@...r.kernel.org, rafael.wang@...ocom.com,
	somashekhar.puttagangaiah@...el.com
Subject: Re: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

On Fri, Jun 23, 2023 at 05:01:42PM +0200, Jose Ignacio Tornos Martinez wrote:
> I have a proposal because at this moment with the current status, t7xx is not
> functional due to problems like this if there is no activity:
> [   57.370534] mtk_t7xx 0000:72:00.0: [PM] SAP suspend error: -110
> [   57.370581] mtk_t7xx 0000:72:00.0: can't suspend
>     (t7xx_pci_pm_runtime_suspend [mtk_t7xx] returned -110)
> and after this the traffic is not working.
> 
> As yu know the situation was stalled and it seems that the final solution for
> the complete series can take longer, so in order to have at least the modem
> working, it would be enough if just the first commit of the series is
> re-applied (d20ef656f994 net: wwan: t7xx: Add AP CLDMA). With that, the
> Application Processor would be controlled, correctly suspended and the
> commented problems would be fixed (I am testing here like this with no related
> issue).
> 
> I think the first commit of the series is independent of the others and it can
> be re-applied cleanly. Later on, the other commits related to fw flashing and 
> coredump collection new features could be added taking into account Bjorn's 
> comments (and of course updated doc if needed).

Please just post your proposal the usual way: send a patch that can be
directly applied, and send it to the maintainers of the file and the
relevant mailing lists.

Since d20ef656f994 affects drivers/net/wwan, this would be handled by
the WWAN folks.  From get_maintainers.pl:

  Loic Poulain <loic.poulain@...aro.org> (maintainer:WWAN DRIVERS)
  Sergey Ryazanov <ryazanov.s.a@...il.com> (maintainer:WWAN DRIVERS)
  Johannes Berg <johannes@...solutions.net> (reviewer:WWAN DRIVERS)
  "David S. Miller" <davem@...emloft.net> (maintainer:NETWORKING DRIVERS)
  Eric Dumazet <edumazet@...gle.com> (maintainer:NETWORKING DRIVERS)
  Jakub Kicinski <kuba@...nel.org> (maintainer:NETWORKING DRIVERS)
  Paolo Abeni <pabeni@...hat.com> (maintainer:NETWORKING DRIVERS)
  netdev@...r.kernel.org (open list:WWAN DRIVERS)
  linux-kernel@...r.kernel.org (open list)

I'm confused about what happened with d20ef656f994 [1].  Git claims it
appeared in v6.1, and I don't see a revert of it, but I don't see the
code changes it made, e.g., the changes to t7xx_hw_info_init() [2].

Bjorn

[1] https://git.kernel.org/linus/d20ef656f994
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wwan/t7xx/t7xx_hif_cldma.c?id=v6.4-rc7#n1063