netdev - Re: [PATCH net-next v4 03/15] ceph: Use sendmsg(MSG_SPLICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2611115.1687549406@warthog.procyon.org.uk>
Date: Fri, 23 Jun 2023 20:43:26 +0100
From: David Howells <dhowells@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>, Ilya Dryomov <idryomov@...il.com>,
    Xiubo Li <xiubli@...hat.com>
Cc: dhowells@...hat.com, netdev@...r.kernel.org,
    Alexander Duyck <alexander.duyck@...il.com>,
    "David S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
    Willem de Bruijn <willemdebruijn.kernel@...il.com>,
    David Ahern <dsahern@...nel.org>,
    Matthew Wilcox <willy@...radead.org>, Jens Axboe <axboe@...nel.dk>,
    linux-mm@...ck.org, linux-kernel@...r.kernel.org,
    Jeff Layton <jlayton@...nel.org>, ceph-devel@...r.kernel.org
Subject: Re: [PATCH net-next v4 03/15] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage

Jakub Kicinski <kuba@...nel.org> wrote:

> >  		if (length == cursor->total_resid)
> > -			more = MSG_MORE;
> > -		ret = ceph_tcp_sendpage(con->sock, page, page_offset, length,
> > -					more);
> > +			msghdr.msg_flags |= MSG_MORE;
> 
> Should the condition also be flipped here, like you did below?
> (can be a follow up if so)

Yeah - the "==" in the if-statement needs flipping to "!=".  I can send a
follow-up patch for it or respin if you prefer.

David