| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <796a0cf2-2411-26e4-5b53-53d560936b7a@linaro.org>
Date: Sat, 24 Jun 2023 10:12:12 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Varshini Rajendran <varshini.rajendran@...rochip.com>,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
claudiu.beznea@...rochip.com, mturquette@...libre.com, sboyd@...nel.org,
herbert@...dor.apana.org.au, davem@...emloft.net, vkoul@...nel.org,
tglx@...utronix.de, maz@...nel.org, lee@...nel.org, ulf.hansson@...aro.org,
tudor.ambarus@...aro.org, miquel.raynal@...tlin.com, richard@....at,
vigneshr@...com, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
linus.walleij@...aro.org, p.zabel@...gutronix.de, olivia@...enic.com,
a.zummo@...ertech.it, radu_nicolae.pirea@....ro, richard.genoud@...il.com,
gregkh@...uxfoundation.org, lgirdwood@...il.com, broonie@...nel.org,
wim@...ux-watchdog.org, linux@...ck-us.net, arnd@...db.de, olof@...om.net,
soc@...nel.org, linux@...linux.org.uk, sre@...nel.org,
jerry.ray@...rochip.com, horatiu.vultur@...rochip.com,
durai.manickamkr@...rochip.com, andrew@...n.ch, alain.volmat@...s.st.com,
neil.armstrong@...aro.org, mihai.sain@...rochip.com,
eugen.hristev@...labora.com, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org, linux-crypto@...r.kernel.org,
dmaengine@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-mmc@...r.kernel.org, linux-mtd@...ts.infradead.org,
netdev@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-rtc@...r.kernel.org, linux-spi@...r.kernel.org,
linux-serial@...r.kernel.org, alsa-devel@...a-project.org,
linux-usb@...r.kernel.org, linux-watchdog@...r.kernel.org,
linux-pm@...r.kernel.org
Cc: Hari.PrasathGE@...rochip.com, cristian.birsan@...rochip.com,
balamanikandan.gunasundar@...rochip.com, manikandan.m@...rochip.com,
dharma.b@...rochip.com, nayabbasha.sayed@...rochip.com,
balakrishnan.s@...rochip.com
Subject: Re: [PATCH v2 45/45] ARM: dts: at91: sam9x75_curiosity: add device
tree for sam9x75 curiosity board
On 23/06/2023 22:30, Varshini Rajendran wrote:
> Add device tree file for sam9x75 curiosity board.
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> ---
> arch/arm/boot/dts/Makefile | 2 +
> arch/arm/boot/dts/at91-sam9x75_curiosity.dts | 336 +++++++++++++++++++
> 2 files changed, 338 insertions(+)
> create mode 100644 arch/arm/boot/dts/at91-sam9x75_curiosity.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 59829fc90315..31f357f8e947 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -53,6 +53,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \
> dtb-$(CONFIG_SOC_SAM9X60) += \
> at91-sam9x60_curiosity.dtb \
> at91-sam9x60ek.dtb
> +dtb-$(CONFIG_SOC_SAM9X7) += \
> + at91-sam9x75_curiosity.dtb
> dtb-$(CONFIG_SOC_SAM_V7) += \
> at91-kizbox2-2.dtb \
> at91-kizbox3-hs.dtb \
> diff --git a/arch/arm/boot/dts/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/at91-sam9x75_curiosity.dts
> new file mode 100644
> index 000000000000..56d3af549201
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sam9x75_curiosity.dts
> @@ -0,0 +1,336 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * at91-sam9x75_curiosity.dts - Device Tree file for Microchip SAM9X75 Curiosity board
> + *
> + * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries
> + *
> + * Author: Varshini Rajendran <varshini.rajendran@...rochip.com>
> + */
> +/dts-v1/;
> +#include "sam9x7.dtsi"
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> + model = "Microchip SAM9X75 Curiosity";
> + compatible = "microchip,sam9x75-curiosity", "microchip,sam9x7", "atmel,at91sam9";
> +
> + aliases {
> + i2c0 = &i2c6;
> + i2c1 = &i2c7;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + clocks {
> + clock-slowxtal {
> + clock-frequency = <32768>;
> + };
> +
> + clock-mainxtal {
> + clock-frequency = <24000000>;
> + };
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_key_gpio_default>;
> + status = "okay";
Why? Did you disable it?
> +
> + button-user {
> + label = "USER";
> + gpios = <&pioC 9 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_PROG1>;
> + wakeup-source;
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_led_gpio_default>;
> + status = "okay";
Why? Did you disable it?
> +
> + led-0 {
> + label = "red";
> + gpios = <&pioC 19 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led-1 {
> + label = "green";
> + gpios = <&pioC 21 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led-2 {
> + label = "blue";
> + gpios = <&pioC 20 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +
> + memory@...00000 {
> + device_type = "memory";
> + reg = <0x20000000 0x10000000>;
> + };
> +};
> +
> +&dbgu {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_dbgu>;
> + status = "okay";
> +};
> +
> +&dma0 {
> + status = "okay";
> +};
> +
> +&ehci0 {
> + status = "okay";
> +};
> +
> +&flx6 {
> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
> + status = "okay";
> +
> + i2c6: i2c@600 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flx6_default>;
> + i2c-analog-filter;
> + i2c-digital-filter;
> + i2c-digital-filter-width-ns = <35>;
> + status = "okay";
Did you disable it? If so this should be overridden by label...
> +
> + mcp16502@5b {
Node names should be generic. See also explanation and list of examples
in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "microchip,mcp16502";
> + reg = <0x5b>;
> + status = "okay";
Srsly, drop.
> +
> + regulators {
> + vdd_3v3: VDD_IO {
> + regulator-name = "VDD_IO";
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3600000>;
...
> +&flx7 {
> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
> + status = "okay";
> +
> + i2c7: i2c@600 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flx7_default>;
> + i2c-analog-filter;
> + i2c-digital-filter;
> + i2c-digital-filter-width-ns = <35>;
> + status = "okay";
Empty bus. Keep disabled. Anyway overrides should be done via label, not
by duplicating children.
> + };
> +};
> +
> +&ohci0 {
> + num-ports = <3>;
> + atmel,vbus-gpio = <0
> + &pioC 27 GPIO_ACTIVE_HIGH
> + &pioB 18 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb_default>;
> + status = "okay";
> +};
> +
> +&pinctrl {
> +
> + dbgu {
> + pinctrl_dbgu: dbgu-0 {
> + atmel,pins = <AT91_PIOA 26 AT91_PERIPH_A AT91_PINCTRL_PULL_UP
> + AT91_PIOA 27 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> + };
> + };
> +
> + flexcom {
> + pinctrl_flx6_default: flx6_twi {
No underscors in node names.
This applies everywhere.
Best regards,
Krzysztof
Powered by blists - more mailing lists