netdev - Re: [Intel-wired-lan] [PATCH] e1000e: Use PME poll to circumvent unreliable ACPI wake

Open Source and information security mailing list archives

Date: Sun, 25 Jun 2023 16:07:11 +0300
From: "Neftin, Sasha" <sasha.neftin@...el.com>
To: naamax.meir <naamax.meir@...ux.intel.com>, Kai-Heng Feng
	<kai.heng.feng@...onical.com>, <jesse.brandeburg@...el.com>,
	<anthony.l.nguyen@...el.com>
CC: <linux-pm@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>,
	<intel-wired-lan@...ts.osuosl.org>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, "Neftin,
 Sasha" <sasha.neftin@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Use PME poll to circumvent
 unreliable ACPI wake

On 6/25/2023 09:28, naamax.meir wrote:
> On 6/1/2023 19:25, Kai-Heng Feng wrote:
>> On some I219 devices, ethernet cable plugging detection only works once
>> from PCI D3 state. Subsequent cable plugging does set PME bit correctly,
>> but device still doesn't get woken up.
>>
>> Since I219 connects to the root complex directly, it relies on platform
>> firmware (ACPI) to wake it up. In this case, the GPE from _PRW only
>> works for first cable plugging but fails to notify the driver for
>> subsequent plugging events.
>>
>> The issue was originally found on CNP, but the same issue can be found
>> on ADL too. So workaround the issue by continuing use PME poll after
>> first ACPI wake. As PME poll is always used, the runtime suspend
>> restriction for CNP can also be removed.
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
>> ---
>>   drivers/net/ethernet/intel/e1000e/netdev.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Tested-by: Naama Meir <naamax.meir@...ux.intel.com>
Acked-by: Sasha Neftin <sasha.neftin@...el.com>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives