netdev - Re: [PATCH net-next v3] net: ngbe: add Wake on Lan support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230626131757.3a7b04c0@kernel.org>
Date: Mon, 26 Jun 2023 13:17:57 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mengyuan Lou <mengyuanlou@...-swift.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] net: ngbe: add Wake on Lan support

On Mon, 26 Jun 2023 16:37:08 +0800 Mengyuan Lou wrote:
> +	if (!wx->wol_hw_supported)
> +		return -EOPNOTSUPP;
> +	if (!(wol->wolopts & WAKE_MAGIC) &&
> +	    wol->wolopts != 0)
> +		return -EOPNOTSUPP;

AFAIK core (by which I mean net/ethtool/* code) already checks that
bits outside of ->supported are not set in wolopts.

Please post v4 after the merge window (in 2 weeks)
-- 
pw-bot: cr