netdev - Re: [PATCH net 0/2] selftests: fix mptcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cfcf26c-739b-8787-3264-b41ff5cbed52@tessares.net>
Date: Mon, 26 Jun 2023 13:28:35 +0200
From: Matthieu Baerts <matthieu.baerts@...sares.net>
To: Andrea Claudi <aclaudi@...hat.com>, netdev@...r.kernel.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: mptcp@...ts.linux.dev, martineau@...nel.org, geliang.tang@...e.com
Subject: Re: [PATCH net 0/2] selftests: fix mptcp_join test

Hi Andrea,

On 23/06/2023 14:19, Andrea Claudi wrote:
> This series fixes two mptcp_join testcases.
> - '001 implicit EP' fails because of:
>   - missing iproute support for mptcp 'implicit' flag, fixed with
>     iproute2-next commit 3a2535a41854 ("mptcp: add support for implicit
>     flag")
>   - pm_nl_check_endpoint expecting two ip addresses, while only one is
>     present in the iproute output;
> - '002 delete and re-add' fails because the endpoint delete command
>   provide both id and ip address, while address should be provided only
>   if id is 0.
> 
> Andrea Claudi (2):
>   selftests: mptcp: join: fix 'delete and re-add' test
>   selftests: mptcp: join: fix 'implicit EP' test

Thank you for these patches!

I have some comments, please see my replies on the individual patches.

Do you mind sending a v2 only to MPTCP ML -- not to Netdev and its
maintainers -- if you don't mind? When these patches will be ready, we
will apply them in MPTCP tree and send them later to netdev.

(Maybe we should modify the MAINTAINERS file to exclude Netdev
maintainers and list when someone sends a patch.)

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net