lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8a832e3d2eb2e3fc14ade43c4feb1cbafc37c5d7.camel@redhat.com>
Date: Tue, 27 Jun 2023 14:47:22 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Vladimir Oltean <olteanv@...il.com>, Vladimir Oltean
	 <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Jose Abreu <Jose.Abreu@...opsys.com>, Andrew
 Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
 linux-kernel@...r.kernel.org, Harini Katakam <harini.katakam@....com>
Subject: Re: [PATCH net] net: phy: mscc: fix packet loss due to RGMII delays

On Tue, 2023-06-27 at 15:13 +0300, Vladimir Oltean wrote:
> On Tue, Jun 27, 2023 at 12:11:09PM +0300, Vladimir Oltean wrote:
> > Two deadly typos break RX and TX traffic on the VSC8502 PHY using RGMII
> > if phy-mode = "rgmii-id" or "rgmii-txid", and no "tx-internal-delay-ps"
> > override exists. The negative error code from phy_get_internal_delay()
> > does not get overridden with the delay deduced from the phy-mode, and
> > later gets committed to hardware. Also, the rx_delay gets overridden by
> > what should have been the tx_delay.
> > 
> > Fixes: dbb050d2bfc8 ("phy: mscc: Add support for RGMII delay configuration")
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> > ---
> 
> I may have mis-targeted this patch towards "net" while the "net-next"
> pull request has not been yet sent out. Can patchwork be instructed to
> re-run the tests on net-next?

I'm not 110% sure, but I think you have to re-send the patch with a
different prefix to achieve the above.

Cheers,

Paolo
> 


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ