netdev - Re: [PATCH v2 net] netlink: Add __sock_i_ino() for __netlink_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 27 Jun 2023 16:50:20 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, kuni1840@...il.com, netdev@...r.kernel.org,
 syzbot+5da61cf6a9bc1902d422@...kaller.appspotmail.com
Subject: Re: [PATCH v2 net] netlink: Add __sock_i_ino() for __netlink_diag_dump().

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 26 Jun 2023 09:43:13 -0700 you wrote:
> syzbot reported a warning in __local_bh_enable_ip(). [0]
> 
> Commit 8d61f926d420 ("netlink: fix potential deadlock in
> netlink_set_err()") converted read_lock(&nl_table_lock) to
> read_lock_irqsave() in __netlink_diag_dump() to prevent a deadlock.
> 
> However, __netlink_diag_dump() calls sock_i_ino() that uses
> read_lock_bh() and read_unlock_bh().  If CONFIG_TRACE_IRQFLAGS=y,
> read_unlock_bh() finally enables IRQ even though it should stay
> disabled until the following read_unlock_irqrestore().
> 
> [...]

Here is the summary with links:
  - [v2,net] netlink: Add __sock_i_ino() for __netlink_diag_dump().
    https://git.kernel.org/netdev/net/c/25a9c8a4431c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html