netdev - RE: [PATCH net] net: phy: mscc: fix packet loss due to RGMII delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BYAPR12MB477315C261B843487E2F21949E27A@BYAPR12MB4773.namprd12.prod.outlook.com>
Date: Tue, 27 Jun 2023 09:19:51 +0000
From: "Katakam, Harini" <harini.katakam@....com>
To: Vladimir Oltean <vladimir.oltean@....com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: Jose Abreu <Jose.Abreu@...opsys.com>, Andrew Lunn <andrew@...n.ch>, Heiner
 Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net] net: phy: mscc: fix packet loss due to RGMII delays



> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@....com>
> Sent: Tuesday, June 27, 2023 2:41 PM
> To: netdev@...r.kernel.org
> Cc: Jose Abreu <Jose.Abreu@...opsys.com>; Andrew Lunn
> <andrew@...n.ch>; Heiner Kallweit <hkallweit1@...il.com>; Russell King
> <linux@...linux.org.uk>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; linux-kernel@...r.kernel.org; Katakam, Harini
> <harini.katakam@....com>
> Subject: [PATCH net] net: phy: mscc: fix packet loss due to RGMII delays
> 
> Two deadly typos break RX and TX traffic on the VSC8502 PHY using RGMII
> if phy-mode = "rgmii-id" or "rgmii-txid", and no "tx-internal-delay-ps"
> override exists. The negative error code from phy_get_internal_delay()
> does not get overridden with the delay deduced from the phy-mode, and
> later gets committed to hardware. Also, the rx_delay gets overridden by
> what should have been the tx_delay.
> 
> Fixes: dbb050d2bfc8 ("phy: mscc: Add support for RGMII delay
> configuration")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Thanks
Reviewed-by: Harini Katakam <harini.katakam@....com>

Regards,
Harini