netdev - Re: [PATCH net v3] net: lan743x: Don't sleep in atomic context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f79e4a6-de12-4c45-9899-d3e07d846c0e@lunn.ch>
Date:   Wed, 28 Jun 2023 16:21:24 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Moritz Fischer <moritz.fischer.private@...il.com>
Cc:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Moritz Fischer <moritzf@...gle.com>, netdev@...r.kernel.org,
        pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
        davem@...emloft.net, bryan.whitehead@...rochip.com,
        UNGLinuxDriver@...rochip.com, stable@...r.kernel.org
Subject: Re: [PATCH net v3] net: lan743x: Don't sleep in atomic context

> Can you clarify if you suggest to leave this alone as-is in patch, or
> replace with something returning one of the errors above?
> 
> If the former, anything else missing in the patch?

I think the patch is O.K. Sorting out the ugly macro is a bigger job,
not something for this patch.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew