netdev - Re: [PATCH net] net/mlx5e: fix double free in mlx5e_destroy_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZJxQvYh/k/5yEDAi@corigine.com>
Date:   Wed, 28 Jun 2023 17:24:45 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, borisp@...dia.com, saeedm@...dia.com,
        leon@...nel.org, tariqt@...dia.com, lkayal@...dia.com,
        yuehaibing@...wei.com
Subject: Re: [PATCH net] net/mlx5e: fix double free in
 mlx5e_destroy_flow_table

On Wed, Jun 28, 2023 at 08:59:34AM +0800, Zhengchao Shao wrote:
> In function accel_fs_tcp_create_groups(), when the ft->g memory is
> successfully allocated but the 'in' memory fails to be allocated, the
> memory pointed to by ft->g is released once. And in function
> accel_fs_tcp_create_table, mlx5e_destroy_flow_table is called to release
> the memory pointed to by ft->g again. This will cause double free problem.
> 
> Fixes: c062d52ac24c ("net/mlx5e: Receive flow steering framework for accelerated TCP flows")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>