netdev - Re: [PATCH bpf-next v4 0/2] libbpf: add netfilter link attach helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3mwjvbobfmmzeuiqeifxdjguk52mitltp3xqj46sozkrgqaeg@xvc6ifaaacpo>
Date:   Wed, 28 Jun 2023 11:08:07 -0600
From:   Daniel Xu <dxu@...uu.xyz>
To:     Florian Westphal <fw@...len.de>
Cc:     bpf@...r.kernel.org, ast@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v4 0/2] libbpf: add netfilter link attach helper

On Wed, Jun 28, 2023 at 05:27:36PM +0200, Florian Westphal wrote:
> v4: address comment from Daniel Xu:
>   - use human-readable test names in 2/2
> 
> v3: address comments from Andrii:
>   - prune verbose error message in 1/2
>   - use bpf_link_create internally in 1/2
>   - use subtests in patch 2/2
> 
> When initial netfilter bpf program type support got added one
> suggestion was to extend libbpf with a helper to ease attachment
> of nf programs to the hook locations.
> 
> Add such a helper and a demo test case that attaches a dummy
> program to various combinations.
> 
> I tested that the selftest fails when changing the expected
> outcome (i.e., set 'success' when it should fail and v.v.).
> 
> Florian Westphal (2):
>   tools: libbpf: add netfilter link attach helper
>   selftests/bpf: Add bpf_program__attach_netfilter helper test
> 
>  tools/lib/bpf/bpf.c                           |  6 ++
>  tools/lib/bpf/bpf.h                           |  6 ++
>  tools/lib/bpf/libbpf.c                        | 42 +++++++++
>  tools/lib/bpf/libbpf.h                        | 15 ++++
>  tools/lib/bpf/libbpf.map                      |  1 +
>  .../bpf/prog_tests/netfilter_link_attach.c    | 86 +++++++++++++++++++
>  .../bpf/progs/test_netfilter_link_attach.c    | 14 +++
>  7 files changed, 170 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/prog_tests/netfilter_link_attach.c
>  create mode 100644 tools/testing/selftests/bpf/progs/test_netfilter_link_attach.c
> 
> -- 
> 2.39.3
> 
> 
For the series:

Acked-by: Daniel Xu <dxu@...uu.xyz>