netdev - Re: [PATCH] net: dsa: vsc73xx: fix MTU configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230628214442.5wucuusl6pqudllk@skbuf>
Date: Thu, 29 Jun 2023 00:44:42 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Pawel Dembicki <paweldembicki@...il.com>
Cc: netdev@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: vsc73xx: fix MTU configuration

On Wed, Jun 28, 2023 at 09:43:27PM +0200, Pawel Dembicki wrote:
> Switch in MAXLEN register stores the maximum size of a data frame.
> The MTU size is 18 bytes smaller than the frame size.
> 
> The current settings are causing problems with packet forwarding.
> This patch fixes the MTU settings to proper values.
> 
> Fixes: fb77ffc6ec86 ("net: dsa: vsc73xx: make the MTU configurable")
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>
> 
> ---
> In my first attempt, I sent it to net-next [0], but I was asked to resend
> it to net.
> 
> [0]https://lore.kernel.org/netdev/20230625115343.1603330-7-paweldembicki@gmail.com/

Just like you had marked those earlier patches as "[PATCH net-next]",
this should have also been marked as "[PATCH v2 net]". Patchwork does
complain about that and deduced the wrong tree, but accepted it anyway
and otherwise ran its tests.
https://patchwork.kernel.org/project/netdevbpf/patch/20230628194327.1765644-1-paweldembicki@gmail.com/

I don't believe there is any reason to resend this patch.

Reviewed-by: Vladimir Oltean <olteanv@...il.com>