netdev - Re: [PATCH] wifi：mac80211: Replace the ternary conditional operator with max()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CTO4IM6NQZ4N.6DC89N410CDS@syracuse>
Date: Wed, 28 Jun 2023 10:00:23 +0200
From: "Nicolas Escande" <nico.escande@...il.com>
To: "Ping-Ke Shih" <pkshih@...ltek.com>, "You Kangren"
 <youkangren@...o.com>, "Johannes Berg" <johannes@...solutions.net>, "David
 S. Miller" <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>,
 "Jakub Kicinski" <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>,
 "open list:MAC80211" <linux-wireless@...r.kernel.org>, "open
 list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>, "open list"
 <linux-kernel@...r.kernel.org>
Cc: "opensource.kernel@...o.com" <opensource.kernel@...o.com>
Subject: Re: [PATCH] wifi：mac80211: Replace the ternary conditional operator with max()

On Wed Jun 28, 2023 at 3:48 AM CEST, Ping-Ke Shih wrote:
>
>
> > -----Original Message-----
> > From: You Kangren <youkangren@...o.com>
> > Sent: Monday, June 26, 2023 6:48 PM
> > To: Johannes Berg <johannes@...solutions.net>; David S. Miller <davem@...emloft.net>; Eric Dumazet
> > <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; open
> > list:MAC80211 <linux-wireless@...r.kernel.org>; open list:NETWORKING [GENERAL] <netdev@...r.kernel.org>;
> > open list <linux-kernel@...r.kernel.org>
> > Cc: opensource.kernel@...o.com; youkangren@...o.com
> > Subject: [PATCH] wifi：mac80211: Replace the ternary conditional operator with max()
>
> The semicolon of "wifi：" is different from others.
>
> > 
> > Replace the ternary conditional operator with max() to make the code clean
> > 
> > Signed-off-by: You Kangren <youkangren@...o.com>
> > ---
> >  net/mac80211/tdls.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/mac80211/tdls.c b/net/mac80211/tdls.c
> > index a4af3b7675ef..9f8b0842a616 100644
> > --- a/net/mac80211/tdls.c
> > +++ b/net/mac80211/tdls.c
> > @@ -946,7 +946,7 @@ ieee80211_tdls_build_mgmt_packet_data(struct ieee80211_sub_if_data *sdata,
> >         int ret;
> >         struct ieee80211_link_data *link;
> > 
> > -       link_id = link_id >= 0 ? link_id : 0;
> > +       link_id = max(link_id, 0);
>
> Original logic means "if link_id < 0, then use default link (0)" instead of
> "always use link_id larger than or equal to 0". So, I think max(link_id, 0) could
> cause misunderstanding. 

I feel the same way, max() implies we want the 'highest' link whereas for me the
actual code really means 'prefer the non default' (zero) link.

>
> >         rcu_read_lock();
> >         link = rcu_dereference(sdata->link[link_id]);
> >         if (WARN_ON(!link))
> > --
> > 2.39.0
> > 
> > 
> > ------Please consider the environment before printing this e-mail.