netdev - Re: [PATCH v3 bpf-next 06/13] bpf: Further refactor alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2023 14:25:45 +0800
From:   Hou Tao <houtao@...weicloud.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     tj@...nel.org, rcu@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org, kernel-team@...com, daniel@...earbox.net,
        andrii@...nel.org, void@...ifault.com, paulmck@...nel.org
Subject: Re: [PATCH v3 bpf-next 06/13] bpf: Further refactor alloc_bulk().



On 6/28/2023 9:56 AM, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@...nel.org>
>
> In certain scenarios alloc_bulk() migth be taking free objects mainly from
> free_by_rcu_ttrace list. In such case get_memcg() and set_active_memcg() are
> redundant, but they show up in perf profile. Split the loop and only set memcg
> when allocating from slab. No performance difference in this patch alone, but
> it helps in combination with further patches.
>
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
Acked-by: Hou Tao <houtao1@...wei.com>