netdev - Re: [PATCH net] mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bkh0eyb0.fsf@nvidia.com>
Date:   Wed, 28 Jun 2023 11:20:22 +0200
From:   Petr Machata <petrm@...dia.com>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <idosch@...dia.com>, <petrm@...dia.com>, <jiri@...nulli.us>,
        <vadimp@...dia.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH net] mlxsw: minimal: fix potential memory leak in
 mlxsw_m_linecards_init


Zhengchao Shao <shaozhengchao@...wei.com> writes:

> when allocating mlxsw_m->line_cards[] failed in mlxsw_m_linecards_init,
> the memory pointed by mlxsw_m->line_cards is not released, which will
> cause memory leak. Memory release processing is added to the incorrect
> path.

Yeah, it's only releasing the memory on cleanup. This function itself
just never releases the array at all.

> Fixes: 01328e23a476 ("mlxsw: minimal: Extend module to port mapping with slot index")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>

Reviewed-by: Petr Machata <petrm@...dia.com>

> ---
>  drivers/net/ethernet/mellanox/mlxsw/minimal.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> index 6b56eadd736e..6b98c3287b49 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> @@ -417,6 +417,7 @@ static int mlxsw_m_linecards_init(struct mlxsw_m *mlxsw_m)
>  err_kmalloc_array:
>  	for (i--; i >= 0; i--)
>  		kfree(mlxsw_m->line_cards[i]);
> +	kfree(mlxsw_m->line_cards);
>  err_kcalloc:
>  	kfree(mlxsw_m->ports);
>  	return err;