netdev - RE: [Intel-wired-lan] [PATCH net-next 2/2] i40e: Wait for pending VF reset in VF set callbacks

Open Source and information security mailing list archives

Message-ID: <BL0PR11MB3521F019D9764F5D09AB87FD8F25A@BL0PR11MB3521.namprd11.prod.outlook.com>
Date: Thu, 29 Jun 2023 13:39:34 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Simon Horman <simon.horman@...igine.com>, ivecera <ivecera@...hat.com>
CC: Ma Yuying <yuma@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	open list <linux-kernel@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "moderated list:INTEL
 ETHERNET DRIVERS" <intel-wired-lan@...ts.osuosl.org>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "David S. Miller"
	<davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next 2/2] i40e: Wait for pending VF
 reset in VF set callbacks

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Simon Horman
> Sent: środa, 14 czerwca 2023 10:27
> To: ivecera <ivecera@...hat.com>
> Cc: Ma Yuying <yuma@...hat.com>; netdev@...r.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@...el.com>; open list <linux-
> kernel@...r.kernel.org>; Eric Dumazet <edumazet@...gle.com>; Nguyen,
> Anthony L <anthony.l.nguyen@...el.com>; moderated list:INTEL ETHERNET
> DRIVERS <intel-wired-lan@...ts.osuosl.org>; Jakub Kicinski
> <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; David S. Miller
> <davem@...emloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH net-next 2/2] i40e: Wait for pending VF
> reset in VF set callbacks
> 
> On Tue, Jun 13, 2023 at 02:16:10PM +0200, Ivan Vecera wrote:
> > Commit 028daf80117376 ("i40e: Fix attach VF to VM issue") fixed a race
> > between i40e_ndo_set_vf_mac() and i40e_reset_vf() during an
> attachment
> > of VF device to VM. This issue is not related to setting MAC address
> > only but also VLAN assignment to particular VF because the newer
> > libvirt sets configured MAC address as well as an optional VLAN. The
> > same behavior is also for i40e's .ndo_set_vf_rate and
> > .ndo_set_vf_spoofchk where the callbacks just check if the VF was
> > initialized but not wait for the finish of pending reset.
> >
> > Reproducer:
> > [root@...t ~]# virsh attach-interface guest hostdev --managed
> > 0000:02:02.0 --mac 52:54:00:b4:aa:bb
> > error: Failed to attach interface
> > error: Cannot set interface MAC/vlanid to 52:54:00:b4:aa:bb/0 for
> > ifname enp2s0f0 vf 0: Resource temporarily unavailable
> >
> > Fix this issue by using i40e_check_vf_init_timeout() helper to check
> > whether a reset of particular VF was finished in i40e's
> > .ndo_set_vf_vlan, .ndo_set_vf_rate and .ndo_set_vf_spoofchk callbacks.
> >
> > Tested-by: Ma Yuying <yuma@...hat.com>
> > Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives