netdev - Re: [PATCH iproute2 5/5] ifstat: fix warning about conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6qqe5mi.fsf@nvidia.com>
Date: Thu, 29 Jun 2023 15:49:49 +0200
From: Petr Machata <me@...chata.org>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 5/5] ifstat: fix warning about conditional


Stephen Hemminger <stephen@...workplumber.org> writes:

> Gcc with warnings enabled complains because the conditional.
>   if ((long)(a - b) < 0)
> could be construed as never true.

Hmm, yeah, it would never be true where sizeof(long) > 4.

>                                    Change to simple comparison.
>
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

Reviewed-by: Petr Machata <me@...chata.org>