netdev - Re: [RFC PATCH 0/4] splice: Fix corruption in data spliced to pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d33f8a7-eb75-4a0d-bb10-aa4ab497c016@mattwhitlock.name>
Date: Thu, 29 Jun 2023 14:16:02 -0400
From: Matt Whitlock <kernel@...twhitlock.name>
To: David Howells <dhowells@...hat.com>
Cc: <netdev@...r.kernel.org>,
 Matthew Wilcox <willy@...radead.org>,
 Dave Chinner <david@...morbit.com>,
 Linus Torvalds <torvalds@...ux-foundation.org>,
 Jens Axboe <axboe@...nel.dk>,
 <linux-fsdevel@...ck.org>,
 <linux-mm@...ck.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 0/4] splice: Fix corruption in data spliced to pipe

On Thursday, 29 June 2023 11:54:29 EDT, David Howells wrote:
> Matt Whitlock, Matthew Wilcox and Dave Chinner are of the opinion that data
> in the pipe must not be seen to change and that if it does, this is a bug.
> Apart from in one specific instance (vmsplice() with SPLICE_F_GIFT), the
> manual pages agree with them.  I'm more inclined to adjust the
> documentation since the behaviour we have has been that way since 2005, I
> think.

Anecdotally, my use case had been working fine for years until I upgraded 
from 5.15.x to 6.1.x in February of this year. That's when my backups 
started being corrupted. I only noticed when I was trying to restore a lost 
file from backup earlier this week.