netdev - Re: [PATCH v1] net: xfrm: Amend XFRMA_SEC_CTX nla

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJ3jSTQFww87vLYn@corigine.com>
Date:   Thu, 29 Jun 2023 22:02:17 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Lin Ma <linma@....edu.cn>
Cc:     steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org, tgraf@...g.ch
Subject: Re: [PATCH v1] net: xfrm: Amend XFRMA_SEC_CTX nla_policy structure

On Tue, Jun 27, 2023 at 01:52:55PM +0800, Lin Ma wrote:
> According to all consumers code of attrs[XFRMA_SEC_CTX], like
> 
> * verify_sec_ctx_len(), convert to xfrm_user_sec_ctx*
> * xfrm_state_construct(), call security_xfrm_state_alloc whose prototype
> is int security_xfrm_state_alloc(.., struct xfrm_user_sec_ctx *sec_ctx);
> * copy_from_user_sec_ctx(), convert to xfrm_user_sec_ctx *
> ...
> 
> It seems that the exptected parsing result for XFRMA_SEC_CTX should be

Hi Lin Ma,

a minor nit via checkpatch.pl --codespell: exptected -> expected

...