netdev - Re: [PATCH net 1/2] net/mlx5e: fix memory leak in mlx5e_fs_tt_redirect_any

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJ1zlcJ/opBKA+5R@corigine.com>
Date:   Thu, 29 Jun 2023 14:05:41 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, richardcochran@...il.com, saeedm@...dia.com,
        leon@...nel.org, lkayal@...dia.com, tariqt@...dia.com,
        gal@...dia.com, rrameshbabu@...dia.com, vadfed@...a.com,
        ayal@...dia.com, eranbe@...dia.com, weiyongjun1@...wei.com,
        yuehaibing@...wei.com
Subject: Re: [PATCH net 1/2] net/mlx5e: fix memory leak in
 mlx5e_fs_tt_redirect_any_create

On Thu, Jun 29, 2023 at 10:46:41AM +0800, Zhengchao Shao wrote:
> The memory pointed to by the fs->any pointer is not freed in the error
> path of mlx5e_fs_tt_redirect_any_create, which can lead to a memory leak.
> Fix by freeing the memory in the error path, thereby making the error path
> identical to mlx5e_fs_tt_redirect_any_destroy().
> 
> Fixes: 0f575c20bf06 ("net/mlx5e: Introduce Flow Steering ANY API")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>