netdev - Re: [PATCH net,v2] mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44c82013-c91a-d7ac-28d0-2f5785c3f942@huawei.com>
Date: Fri, 30 Jun 2023 08:55:25 +0800
From: shaozhengchao <shaozhengchao@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <idosch@...dia.com>, <petrm@...dia.com>,
	<jiri@...nulli.us>, <vadimp@...dia.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH net,v2] mlxsw: minimal: fix potential memory leak in
 mlxsw_m_linecards_init



On 2023/6/30 2:08, Jakub Kicinski wrote:
> On Wed, 28 Jun 2023 18:01:16 +0800 Zhengchao Shao wrote:
>> The line cards array is not freed in the error path of
>> mlxsw_m_linecards_init(), which can lead to a memory leak. Fix by
>> freeing the array in the error path, thereby making the error path
>> identical to mlxsw_m_linecards_fini().
>>
>> Fixes: 01328e23a476 ("mlxsw: minimal: Extend module to port mapping with slot index")
>> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
>> Reviewed-by: Petr Machata <petrm@...dia.com>
> 
> Could you please resend with Ido's review tag included?
> 
  OK，I will resend this patch. Thank you.

Zhengchao Shao
> Due to unforeseen mail server issues (it wouldn't be a merge window
> without vger imploding, eh?) the patch did not make it to patchwork
> or email archives.