netdev - Re: [PATCH net,v2 1/2] net/mlx5e: fix memory leak in mlx5e_fs_tt_redirect_any

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877crlbpt0.fsf@nvidia.com>
Date: Thu, 29 Jun 2023 20:18:51 -0700
From: Rahul Rameshbabu <rrameshbabu@...dia.com>
To: Zhengchao Shao <shaozhengchao@...wei.com>
Cc: <netdev@...r.kernel.org>,  <linux-rdma@...r.kernel.org>,
  <davem@...emloft.net>,  <edumazet@...gle.com>,  <kuba@...nel.org>,
  <pabeni@...hat.com>,  <richardcochran@...il.com>,  <saeedm@...dia.com>,
  <leon@...nel.org>,  <lkayal@...dia.com>,  <tariqt@...dia.com>,
  <gal@...dia.com>,  <vadfed@...a.com>,  <ayal@...dia.com>,
  <eranbe@...dia.com>,  <weiyongjun1@...wei.com>,  <yuehaibing@...wei.com>
Subject: Re: [PATCH net,v2 1/2] net/mlx5e: fix memory leak in
 mlx5e_fs_tt_redirect_any_create

On Fri, 30 Jun, 2023 09:49:02 +0800 Zhengchao Shao <shaozhengchao@...wei.com> wrote:
> The memory pointed to by the fs->any pointer is not freed in the error
> path of mlx5e_fs_tt_redirect_any_create, which can lead to a memory leak.
> Fix by freeing the memory in the error path, thereby making the error path
> identical to mlx5e_fs_tt_redirect_any_destroy().
>
> Fixes: 0f575c20bf06 ("net/mlx5e: Introduce Flow Steering ANY API")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> ---
> v2: update the 'any' member reference in fs to NULL before free fs_any
> ---

Thank you for contributing.

Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>