netdev - Re: [PATCH iproute2-next] f_flower: simplify cfm dump function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87leg1xkax.fsf@nvidia.com>
Date: Fri, 30 Jun 2023 13:22:45 +0200
From: Petr Machata <me@...chata.org>
To: Zahari Doychev <zahari.doychev@...ux.com>
Cc: netdev@...r.kernel.org, dsahern@...il.com, stephen@...workplumber.org,
 hmehrtens@...linear.com, aleksander.lobakin@...el.com,
 simon.horman@...igine.com, idosch@...sch.org, Zahari Doychev
 <zdoychev@...linear.com>
Subject: Re: [PATCH iproute2-next] f_flower: simplify cfm dump function


Zahari Doychev <zahari.doychev@...ux.com> writes:

> From: Zahari Doychev <zdoychev@...linear.com>
>
> The standard print function can be used to print the cfm attributes in
> both standard and json use cases. In this way no string buffer is needed
> which simplifies the code.

This looks correct, but please make sure that the diff between the old
and the new way is empty in both JSON and FP mode.

> Signed-off-by: Zahari Doychev <zdoychev@...linear.com>

Reviewed-by: Petr Machata <me@...chata.org>