netdev - Re: [PATCH net-next] tcp: Make GRO completion function inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9d7579c-f717-bfea-89c9-cf13b9b79a86@kernel.org>
Date: Mon, 3 Jul 2023 11:29:56 -0600
From: David Ahern <dsahern@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>,
 Michael Chan <michael.chan@...adcom.com>, Parav Pandit <parav@...dia.com>
Cc: aelior@...vell.com, skalluru@...vell.com, manishc@...vell.com,
 netdev@...r.kernel.org, edumazet@...gle.com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next] tcp: Make GRO completion function inline

On 7/3/23 10:51 AM, Alexander Lobakin wrote:
> Why is this needed then if it gives nothing? :D

It is a question I asked. There are a fair number of trivial sk_buff
functions called in the datapath (e.g., skb_add_rx_frag is another).
Function calls are not free, so inlining them should *collectively*
provide measurable performance bumps as line rates and packet rates
increase.