netdev - Regression: supported_interfaces filling enforcement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABikg9wM0f5cjYY0EV_i3cMT2JcUT1bSe_kkiYk0wFwMrTo8=w@mail.gmail.com>
Date: Tue, 4 Jul 2023 17:28:47 +0300
From: Sergei Antonov <saproj@...il.com>
To: netdev@...r.kernel.org, Vladimir Oltean <olteanv@...il.com>, rmk+kernel@...linux.org.uk
Subject: Regression: supported_interfaces filling enforcement

Hello!
This commit seems to break the mv88e6060 dsa driver:
de5c9bf40c4582729f64f66d9cf4920d50beb897    "net: phylink: require
supported_interfaces to be filled"

The driver does not fill 'supported_interfaces'. What is the proper
way to fix it? I managed to fix it by the following quick code.
Comments? Recommendations?

+static void mv88e6060_get_caps(struct dsa_switch *ds, int port,
+                              struct phylink_config *config)
+{
+       __set_bit(PHY_INTERFACE_MODE_INTERNAL, config->supported_interfaces);
+       __set_bit(PHY_INTERFACE_MODE_GMII, config->supported_interfaces);
+}
+
 static const struct dsa_switch_ops mv88e6060_switch_ops = {
        .get_tag_protocol = mv88e6060_get_tag_protocol,
        .setup          = mv88e6060_setup,
        .phy_read       = mv88e6060_phy_read,
        .phy_write      = mv88e6060_phy_write,
+       .phylink_get_caps = mv88e6060_get_caps
 };