netdev - Re: [PATCH v1] net/sched: act_pedit: Add size check for TCA_PEDIT_PARMS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 04 Jul 2023 12:50:20 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Lin Ma <linma@....edu.cn>
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH v1] net/sched: act_pedit: Add size check for
 TCA_PEDIT_PARMS_EX

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Mon,  3 Jul 2023 19:08:42 +0800 you wrote:
> The attribute TCA_PEDIT_PARMS_EX is not be included in pedit_policy and
> one malicious user could fake a TCA_PEDIT_PARMS_EX whose length is
> smaller than the intended sizeof(struct tc_pedit). Hence, the
> dereference in tcf_pedit_init() could access dirty heap data.
> 
> static int tcf_pedit_init(...)
> {
>   // ...
>   pattr = tb[TCA_PEDIT_PARMS]; // TCA_PEDIT_PARMS is included
>   if (!pattr)
>     pattr = tb[TCA_PEDIT_PARMS_EX]; // but this is not
> 
> [...]

Here is the summary with links:
  - [v1] net/sched: act_pedit: Add size check for TCA_PEDIT_PARMS_EX
    https://git.kernel.org/netdev/net/c/30c45b5361d3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html