netdev - Re: R: Why we need add :: at the last when encap seg6 with inline mode?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ZKOIgDp4DIXV2Aj4@Laptop-X1>
Date: Tue, 4 Jul 2023 10:48:32 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: paolo lungaroni <paolo.lungaroni@...mni.uniroma2.eu>
Cc: Andrea Mayer <andrea.mayer@...roma2.it>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"stefano.salsano" <stefano.salsano@...roma2.it>,
	Ahmed Abdelsalam <ahabdels.dev@...il.com>,
	David Lebrun <dlebrun@...gle.com>
Subject: Re: R: Why we need add :: at the last when encap seg6 with inline
 mode?

Hi Paolo,
On Thu, Jun 29, 2023 at 10:57:32PM +0000, paolo lungaroni wrote:
> Just for the sake of clarity let's consider Example 1 where the SID List is
> built as follows: <S3,S2,S1>.
> 
> Before applying H.Insert
>    IPv6 DA=B2
> 
> After applying H.Insert:
>    IPv6 DA=S1 | SRH <B2,S3,S2,S1>
> 
> In this representation, we stick with the draft conventions where the SID List
> is represented in the reversed order. That means that S1 will be the first SID,
> S2 the second one, etc. B2 is the original IPv6 DA that is pushed into the
> SID List and will be restored once the SRH is removed.
> 
> Now let's consider the H.Insert implementation in Linux.
> 
> User space
> =========
> 
> Currently, when a H.Insert tunnel is instantiated the userspace (iproute2, in
> this case) acquires all the info (e.g. inline, segs, etc) from the CLI and
> builds directly the required SRH header [2].
> Considering the H.Insert tunnel (i.e. inline mode), parse_srh() (line 894)
> accommodates for an extra space required to store the original IPv6 DA (i.e.
> B2 considering the Example 1) which is not known at the moment of the tunnel
> creation.
> For this reason, iproute2 fills the reserved space with 16 bytes set to zero
> (and that's why we see ::).

Thanks for the explanation. Compared with dealing each segment route and
adding the original DA in the middle of struct ipv6_sr_hdr, this way looks
more easier. Although the users may feel a little confused :)

Regards
Hangbin