netdev - Re: [PATCH net] s390/qeth: Fix vipa deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 4 Jul 2023 21:43:04 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Alexandra Winter <wintera@...ux.ibm.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	Heiko Carstens <hca@...ux.ibm.com>,
	Thorsten Winkler <twinkler@...ux.ibm.com>,
	Wenjia Zhang <wenjia@...ux.ibm.com>
Subject: Re: [PATCH net] s390/qeth: Fix vipa deletion

On Tue, Jul 04, 2023 at 04:41:21PM +0200, Alexandra Winter wrote:
> From: Thorsten Winkler <twinkler@...ux.ibm.com>
> 
> Change boolean parameter of function "qeth_l3_vipa_store" inside the
> "qeth_l3_dev_vipa_del4_store" function from "true" to "false" because
> "true" is used for adding a virtual ip address and "false" for deleting.
> 
> Fixes: 2390166a6b45 ("s390/qeth: clean up L3 sysfs code")
> 

nit: no blank line here.

> Reviewed-by: Alexandra Winter <wintera@...ux.ibm.com>
> Reviewed-by: Wenjia Zhang <wenjia@...ux.ibm.com>
> Signed-off-by: Thorsten Winkler <twinkler@...ux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>