netdev - Re: [PATCH v4] net: xfrm: Amend XFRMA_SEC_CTX nla

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZKOx+MPDbCpESzwi@gauss3.secunet.de>
Date: Tue, 4 Jul 2023 07:45:28 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Lin Ma <linma@....edu.cn>
CC: <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<netdev@...r.kernel.org>, <tgraf@...g.ch>, <simon.horman@...igine.com>
Subject: Re: [PATCH v4] net: xfrm: Amend XFRMA_SEC_CTX nla_policy structure

On Fri, Jun 30, 2023 at 04:19:11PM +0800, Lin Ma wrote:
> According to all consumers code of attrs[XFRMA_SEC_CTX], like
> 
> * verify_sec_ctx_len(), convert to xfrm_user_sec_ctx*
> * xfrm_state_construct(), call security_xfrm_state_alloc whose prototype
> is int security_xfrm_state_alloc(.., struct xfrm_user_sec_ctx *sec_ctx);
> * copy_from_user_sec_ctx(), convert to xfrm_user_sec_ctx *
> ...
> 
> It seems that the expected parsing result for XFRMA_SEC_CTX should be
> structure xfrm_user_sec_ctx, and the current xfrm_sec_ctx is confusing
> and misleading (Luckily, they happen to have same size 8 bytes).
> 
> This commit amend the policy structure to xfrm_user_sec_ctx to avoid
> ambiguity.
> 
> Fixes: cf5cb79f6946 ("[XFRM] netlink: Establish an attribute policy")
> Signed-off-by: Lin Ma <linma@....edu.cn>

Applied, thanks a lot Lin!