netdev - Re: [PATCH 3/4] igb: add AF_XDP zero-copy Rx support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 6 Jul 2023 01:16:31 +0800
From: kernel test robot <lkp@...el.com>
To: Sriram Yagnaraman <sriram.yagnaraman@....tech>
Cc: oe-kbuild-all@...ts.linux.dev, intel-wired-lan@...ts.osuosl.org,
	bpf@...r.kernel.org, netdev@...r.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Tony Nguyen <anthony.l.nguyen@...el.com>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	John Fastabend <john.fastabend@...il.com>,
	Sriram Yagnaraman <sriram.yagnaraman@....tech>
Subject: Re: [PATCH 3/4] igb: add AF_XDP zero-copy Rx support

Hi Sriram,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tnguy-next-queue/dev-queue]
[also build test WARNING on tnguy-net-queue/dev-queue horms-ipvs/master linus/master v6.4 next-20230705]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sriram-Yagnaraman/igb-prepare-for-AF_XDP-zero-copy-support/20230704-180613
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
patch link:    https://lore.kernel.org/r/20230704095915.9750-4-sriram.yagnaraman%40est.tech
patch subject: [PATCH 3/4] igb: add AF_XDP zero-copy Rx support
config: openrisc-randconfig-r093-20230705 (https://download.01.org/0day-ci/archive/20230706/202307060154.LjqekYIL-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230706/202307060154.LjqekYIL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307060154.LjqekYIL-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/intel/igb/igb_main.c:2016:32: sparse: sparse: incompatible types in conditional expression (different base types):
>> drivers/net/ethernet/intel/igb/igb_main.c:2016:32: sparse:    bool
>> drivers/net/ethernet/intel/igb/igb_main.c:2016:32: sparse:    void
   drivers/net/ethernet/intel/igb/igb_main.c:4920:27: sparse: sparse: incompatible types in conditional expression (different base types):
   drivers/net/ethernet/intel/igb/igb_main.c:4920:27: sparse:    bool
   drivers/net/ethernet/intel/igb/igb_main.c:4920:27: sparse:    void

vim +2016 drivers/net/ethernet/intel/igb/igb_main.c

  1984	
  1985	/**
  1986	 *  igb_configure - configure the hardware for RX and TX
  1987	 *  @adapter: private board structure
  1988	 **/
  1989	static void igb_configure(struct igb_adapter *adapter)
  1990	{
  1991		struct net_device *netdev = adapter->netdev;
  1992		int i;
  1993	
  1994		igb_get_hw_control(adapter);
  1995		igb_set_rx_mode(netdev);
  1996		igb_setup_tx_mode(adapter);
  1997	
  1998		igb_restore_vlan(adapter);
  1999	
  2000		igb_setup_tctl(adapter);
  2001		igb_setup_mrqc(adapter);
  2002		igb_setup_rctl(adapter);
  2003	
  2004		igb_nfc_filter_restore(adapter);
  2005		igb_configure_tx(adapter);
  2006		igb_configure_rx(adapter);
  2007	
  2008		igb_rx_fifo_flush_82575(&adapter->hw);
  2009	
  2010		/* call igb_desc_unused which always leaves
  2011		 * at least 1 descriptor unused to make sure
  2012		 * next_to_use != next_to_clean
  2013		 */
  2014		for (i = 0; i < adapter->num_rx_queues; i++) {
  2015			struct igb_ring *ring = adapter->rx_ring[i];
> 2016			ring->xsk_pool ?
  2017				igb_alloc_rx_buffers_zc(ring, igb_desc_unused(ring)) :
  2018				igb_alloc_rx_buffers(ring, igb_desc_unused(ring));
  2019		}
  2020	}
  2021	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki