netdev - Re: [PATCH v2 net] ionic: remove WARN_ON to prevent panic_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75f89fd0-191e-0248-89d1-aa9f1bad715a@intel.com>
Date: Thu, 6 Jul 2023 12:55:40 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Shannon Nelson <shannon.nelson@....com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <kuba@...nel.org>
CC: <brett.creeley@....com>, <drivers@...sando.io>, <nitya.sunkad@....com>
Subject: Re: [PATCH v2 net] ionic: remove WARN_ON to prevent panic_on_warn



On 7/6/2023 11:20 AM, Shannon Nelson wrote:
> From: Nitya Sunkad <nitya.sunkad@....com>
> 
> Remove unnecessary early code development check and the WARN_ON
> that it uses.  The irq alloc and free paths have long been
> cleaned up and this check shouldn't have stuck around so long.
> 
> Fixes: 77ceb68e29cc ("ionic: Add notifyq support")
> Signed-off-by: Nitya Sunkad <nitya.sunkad@....com>
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>
> ---
> v2:
> - Remove unnecessary n_qcq->flags & IONIC_QCQ_F_INTR check from early
>   development
> 

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 7c20a44e549b..612b0015dc43 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -475,11 +475,6 @@ static void ionic_qcqs_free(struct ionic_lif *lif)
>  static void ionic_link_qcq_interrupts(struct ionic_qcq *src_qcq,
>  				      struct ionic_qcq *n_qcq)
>  {
> -	if (WARN_ON(n_qcq->flags & IONIC_QCQ_F_INTR)) {
> -		ionic_intr_free(n_qcq->cq.lif->ionic, n_qcq->intr.index);
> -		n_qcq->flags &= ~IONIC_QCQ_F_INTR;
> -	}
> -
>  	n_qcq->intr.vector = src_qcq->intr.vector;
>  	n_qcq->intr.index = src_qcq->intr.index;
>  	n_qcq->napi_qcq = src_qcq->napi_qcq;